Use full paths to images #311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi! Did you read the last Note in the original comment? |
Member
|
Now fixed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial does not use full paths to the images fore.xpm and mditestbg.xpm. These images are therefore not found during execution.
The image on the documentation page therefore does not look as expected:
https://root.cern/doc/master/rose__image_8C.html
E.g. the text in the lower right corner of the images is barely readable due to this problem.
This pull request addresses this issue.
Note: I have used TROOT::GetTutorialDir() instead of TROOT::GetTutorialsDir() since I apply this change after appling the changes in pull request #130. If you decide to fix this issue first you need to put the s back in.