[v628][RF] Backports of RooFit PRs to v6-28-00-patches: Part 11
#12321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_mode` is the analytical integral code, not the integral operation mode
|
Starting build on |
6 tasks
This reformatting is done now because the files will be changed in the following commit, and the differences to the ROOT code style were already minor
Trying to make a documentation page for RooBrowser
Since a few weeks, having pdfs with the same name in a RooSimultaneous fit with BatchMode didn't work anymore. This was because when setting up the computation graph for a given normalization set, all pdfs are cloned and redirected with `RooAbsArg::redirectServers()`, which doesn't work if servers have the same name. This commit suggests to instead delete the pdf servers and proxies and then recreate them by hand. Also, the logic of `RooSimultaneous::compileForNormSet()` was updated to iterate directly over the pdfs instead of iterating over the index categories and then getting the pdfs. The unit tests in `testAbsPdf` are now also parametrized to cover both BatchMode on and off, such that the case of the `RooSimultaneous` with one pdf in used in two channels is also covered buy the tests for BatchMode.
In `RooAbsCategoryLValue::setBin()`, there is a check for passing a named binning, because the function doesn't support named binnings. However, if a binning with that name doesn't exist, it is fine to not error out, because the default range is used.
In particular, use less TString.
Also, use `nullptr` instead of `0` literal in `getBinningPtr()`.
The code branch without a proto data in `RooGenContext` already did this, and now it's also done when using proto dataset generation. Closes root-project#12286.
guitargeek
force-pushed
the
v6-28-00-patches_roofit_backports_11
branch
from
57e4c9e to
4c1558c
Compare
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of all the relevant RooFit PRs that were recently merged to master to v6-28-00-patches (in the right order, to not have the commit history diverge too much).
RooAbsCategoryLValue::setBin()for non-existing ranges #12305Related to #12319.