Fix build with -Dbuiltin_gtest:BOOL=OFF on EPEL 8 #12250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellert
requested review from
guitargeek,
hageboeck and
lmoneta
as code owners
|
Starting build on |
52 tasks
guitargeek
approved these changes
Feb 8, 2023
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you! I thought I have added this for all the new tests, but I see I forgot some, sorry.
I'll also take care of the backport to the 6.28 branch, so this gets included in the ROOT 6.28.02 patch release.
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Some new tests need the backward compatibility tweaks to work with the system gtest on RHEL/EPEL 8.
Checklist:
This PR fixes #