[RF] Support RooAbsCategoryLValue::setBin() for non-existing ranges
#12305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `RooAbsCategoryLValue::setBin()`, there is a check for passing a named binning, because the function doesn't support named binnings. However, if a binning with that name doesn't exist, it is fine to not error out, because the default range is used.
In particular, use less TString.
Also, use `nullptr` instead of `0` literal in `getBinningPtr()`.
|
Starting build on |
This was referenced Feb 13, 2023
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
RooAbsCategoryLValue::setBin(), there is a check for passing anamed binning, because the function doesn't support named binnings.
However, if a binning with that name doesn't exist, it is fine to not
error out, because the default range is used.
This supports the fit in this forum post:
https://root-forum.cern.ch/t/roosimultaneous-and-roofftconvpdf/53606
There are also two additional commits with some code modernization as usual.