Enable restoring an earlier snapshot if latest fails#4222
Open
pcholakov wants to merge 3 commits intoscan-sweep-snapshot-pruningfrom
Open
Enable restoring an earlier snapshot if latest fails#4222pcholakov wants to merge 3 commits intoscan-sweep-snapshot-pruningfrom
pcholakov wants to merge 3 commits intoscan-sweep-snapshot-pruningfrom
Conversation
pcholakov
changed the title
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
3 times, most recently
from
2f139b0 to
765f99f
Compare
This was referenced Jan 20, 2026
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
from
765f99f to
56e86cb
Compare
pcholakov
force-pushed
the
scan-sweep-snapshot-pruning
branch
from
896f467 to
71fca12
Compare
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
from
56e86cb to
19f6c7d
Compare
pcholakov
force-pushed
the
scan-sweep-snapshot-pruning
branch
from
71fca12 to
cf1468b
Compare
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
2 times, most recently
from
f3138ae to
43dea07
Compare
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
from
43dea07 to
933bc78
Compare
pcholakov
force-pushed
the
scan-sweep-snapshot-pruning
branch
from
cf1468b to
5560969
Compare
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
from
933bc78 to
4610813
Compare
pcholakov
force-pushed
the
scan-sweep-snapshot-pruning
branch
2 times, most recently
from
78e783c to
86d09a1
Compare
When the latest snapshot fails to download (network error, corrupt metadata, missing files), the system now automatically tries older retained snapshots in descending LSN order until one succeeds or all candidates are exhausted.
pcholakov
force-pushed
the
snapshot-restore-fallback
branch
from
4610813 to
7bcfd3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the partition store attempt restoring from an earlier snapshot, if the latest one fails. This could be because of missing or corrupt SSTs for example.
The PR also contains an in-tree snapshot chaos test which stresses incremental snapshots and the restore path, by killing nodes and corrupting the latest snapshot by removing some of its SSTs.
Fixes #3930