Skip to content

Add orphaned snapshot objects pruning#4212

Open
pcholakov wants to merge 3 commits intoincremental-snapshotsfrom
scan-sweep-snapshot-pruning
Open

Add orphaned snapshot objects pruning#4212
pcholakov wants to merge 3 commits intoincremental-snapshotsfrom
scan-sweep-snapshot-pruning

Conversation

@pcholakov
Copy link
Contributor

@pcholakov pcholakov commented Jan 19, 2026

This PR adds a sweep-based cleanup mechanism to prune orphaned SST objects and metadata files from the object store. Since enabling this would impact pre-existing snapshots, this behavior is opt-in.

Related PRs (earliest to latest)

  1. Add support for managing a fixed number of retained snapshots #3942
  2. Introduce leases for snapshot coordination #4204
  3. Add incremental snapshot support #4198
  4. Add orphaned snapshot objects pruning #4212 ⬅️ you are here
  5. Enable restoring an earlier snapshot if latest fails #4222

@github-actions
Copy link

github-actions bot commented Jan 19, 2026

Test Results

  7 files    7 suites   2m 41s ⏱️
 47 tests  47 ✅ 0 💤 0 ❌
200 runs  200 ✅ 0 💤 0 ❌

Results for commit 86d09a1.

♻️ This comment has been updated with latest results.

@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch from e36fb21 to 658c316 Compare January 19, 2026 20:20
@pcholakov pcholakov changed the title Scan sweep snapshot pruning Add orphaned snapshot objects pruning Jan 19, 2026
@pcholakov pcholakov force-pushed the incremental-snapshots branch from 6e31300 to 7bfffab Compare January 20, 2026 09:19
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch from 658c316 to f5450a9 Compare January 20, 2026 09:25
@pcholakov pcholakov force-pushed the incremental-snapshots branch 2 times, most recently from ef734f0 to 110115e Compare January 20, 2026 09:50
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch from f5450a9 to 6f4a418 Compare January 20, 2026 10:00
@pcholakov pcholakov force-pushed the incremental-snapshots branch from 110115e to fdfe0d1 Compare January 20, 2026 10:16
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch 5 times, most recently from c1805ea to 896f467 Compare January 20, 2026 15:41
@pcholakov pcholakov marked this pull request as ready for review January 20, 2026 15:44
@pcholakov pcholakov force-pushed the incremental-snapshots branch from fdfe0d1 to fb3d0f0 Compare January 21, 2026 09:31
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch from 896f467 to 71fca12 Compare January 21, 2026 09:31
@pcholakov pcholakov force-pushed the incremental-snapshots branch from fb3d0f0 to 45efcdf Compare January 21, 2026 10:38
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch from 71fca12 to cf1468b Compare January 21, 2026 10:38
@pcholakov pcholakov force-pushed the incremental-snapshots branch from 45efcdf to b286326 Compare January 29, 2026 18:46
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch 2 times, most recently from 5560969 to 78e783c Compare February 1, 2026 10:09
@pcholakov pcholakov force-pushed the incremental-snapshots branch 2 times, most recently from 3f65f6f to 76338d9 Compare February 1, 2026 19:02
@pcholakov pcholakov force-pushed the scan-sweep-snapshot-pruning branch from 78e783c to 86d09a1 Compare February 1, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant