Open
Conversation
pcholakov
force-pushed
the
incremental-snapshots
branch
from
63f4f05 to
70fa77f
Compare
pcholakov
force-pushed
the
pavel/qnkxqqrvzqyx
branch
from
9ade819 to
6d2aad0
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
5 times, most recently
from
a9b66d2 to
754225f
Compare
pcholakov
force-pushed
the
pavel/qnkxqqrvzqyx
branch
from
6d2aad0 to
2d2e754
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
2 times, most recently
from
93f9a83 to
8d4a315
Compare
pcholakov
force-pushed
the
pavel/qnkxqqrvzqyx
branch
from
2d2e754 to
dad6042
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
8d4a315 to
6e31300
Compare
This was referenced Jan 19, 2026
pcholakov
force-pushed
the
pavel/qnkxqqrvzqyx
branch
from
dad6042 to
264bb2c
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
6e31300 to
7bfffab
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
2 times, most recently
from
ef734f0 to
110115e
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
110115e to
fdfe0d1
Compare
pcholakov
commented
Jan 20, 2026
| } | ||
| } | ||
|
|
||
| async fn compute_content_hash(path: &Path) -> io::Result<ContentHash> { |
Contributor
Author
There was a problem hiding this comment.
If we think it would be beneficial I can convert this to mmap - I didn't want to introduce new dependencies, haven't really tested this for performance so tips for obvious improvements welcome!
pcholakov
force-pushed
the
incremental-snapshots
branch
from
fdfe0d1 to
fb3d0f0
Compare
pcholakov
force-pushed
the
snapshot-leases
branch
from
c4a6ca9 to
6fbaf28
Compare
pcholakov
force-pushed
the
snapshot-leases
branch
from
6fbaf28 to
a113539
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
fb3d0f0 to
45efcdf
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
45efcdf to
b286326
Compare
pcholakov
force-pushed
the
snapshot-leases
branch
from
a113539 to
151d6c7
Compare
Use content-based hash naming for shared SSTs Add config option to set snapshot startup delay resolve: incremental snapshot support conflict
resolve conflicts in vwrmvrwu
pcholakov
force-pushed
the
snapshot-leases
branch
from
151d6c7 to
330e2cb
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
b286326 to
3f65f6f
Compare
pcholakov
force-pushed
the
incremental-snapshots
branch
from
3f65f6f to
76338d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #4205 and adds incremental snapshots based on SST content-hash deduplication.
Related PRs (earliest to latest)