Skip to content

Add Wrangler v4 to @react-router/dev peer dep range #13258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

matthewlynch
Copy link
Contributor

@matthewlynch matthewlynch commented Mar 19, 2025

@markdalgleish I realised I had opened my last MR from the main branch so I have corrected to use dev. I've made all the changes requested in #13225.

@matthewlynch
Copy link
Contributor Author

I'll debug failing checks locally

1) Set compatibility_date to remove warnings about the date missing
2) Remove wrangler type import from generated load-context.ts file - I've aligned the types with the cloudflare template
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 5caf840

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 20, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@matthewlynch
Copy link
Contributor Author

The tests for the related change seem to pass now:

matthewlynch@Matts-MacBook-Pro react-router % pnpm test:integration --project=webkit integration/vite-cloudflare-test.ts

> @remix-run/react-router@ test:integration /Users/matthewlynch/Projects/react-router
> pnpm build && pnpm test:integration:run "--project=webkit" "integration/vite-cloudflare-test.ts"


> @remix-run/react-router@ build /Users/matthewlynch/Projects/react-router
> pnpm run --filter="./packages/**/*" build

Scope: 11 of 25 workspace projects
packages/create-react-router build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 139ms
packages/react-router build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 143ms
packages/react-router-cloudflare build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 130ms
packages/react-router-node build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 130ms
packages/react-router-dom build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 130ms
packages/react-router-architect build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 127ms
packages/react-router-express build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 127ms
packages/react-router-serve build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 122ms
packages/react-router-dev build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 137ms
...ct-router-remix-routes-option-adapter build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 122ms
packages/react-router-fs-routes build$ wireit
│ Analyzing
│ ✅ Ran 0 scripts and skipped 1 in 0s.
└─ Done in 122ms

> @remix-run/react-router@ test:integration:run /Users/matthewlynch/Projects/react-router
> pnpm playwright:integration "--project=webkit" "integration/vite-cloudflare-test.ts"


> @remix-run/react-router@ playwright:integration /Users/matthewlynch/Projects/react-router
> playwright test --config ./integration/playwright.config.ts "--project=webkit" "integration/vite-cloudflare-test.ts"


Running 4 tests using 4 workers
  4 passed (4.5s)

To open last HTML report run:

  pnpm exec playwright show-report integration/playwright-report


> @remix-run/react-router@ posttest:integration:run /Users/matthewlynch/Projects/react-router
> pnpm clean:integration


> @remix-run/react-router@ clean:integration /Users/matthewlynch/Projects/react-router
> node ./integration/helpers/cleanup.mjs

Removing .tmp/integration

@matthewlynch
Copy link
Contributor Author

Let me know if there is anything else that needs to be done on the MR - thanks!

@markdalgleish
Copy link
Member

Just one comment on the peer dependency range, but otherwise this is looking good.

@matthewlynch
Copy link
Contributor Author

Done - thanks again for taking the time to review

@markdalgleish markdalgleish changed the title upgrade wrangler to v4 Add Wrangler v4 to @react-router/dev peer dependency range Mar 27, 2025
@markdalgleish markdalgleish changed the title Add Wrangler v4 to @react-router/dev peer dependency range Add Wrangler v4 to @react-router/dev peer dep range Mar 27, 2025
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit 0bd23d9 into remix-run:dev Mar 27, 2025
10 of 11 checks passed
@matthewlynch matthewlynch deleted the dev branch March 27, 2025 11:53
@WillSmithTE
Copy link
Contributor

More of a general question, but how do I get notified when a particular commit (this one) is published in a version?

Copy link
Contributor

github-actions bot commented Apr 2, 2025

🤖 Hello there,

We just published version 7.5.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

wilcoxmd added a commit to wilcoxmd/react-router that referenced this pull request Apr 3, 2025
…d-route-typegen

* upstream/dev: (56 commits)
  chore: format
  feat: unstable_subResourceIntegrity (remix-run#13163)
  Add lazy route property API, use for loading middleware (remix-run#13294)
  Add `rolldown-vite` playground (remix-run#13333)
  chore: Update version for release (remix-run#13322)
  Exit prerelease mode
  Update release notes
  Remove `react-router:override-optimize-deps` plugin (remix-run#13317)
  chore: format
  Add Wrangler v4 to `@react-router/dev` peer dep range (remix-run#13258)
  update changelog
  Handle custom base for critical CSS with Vite Env API (remix-run#13305)
  chore: Update version for release (pre) (remix-run#13312)
  Enter prerelease mode
  chore: format
  host parse (remix-run#13309)
  Fix middleware return types (remix-run#13311)
  more data docs
  fix Location link (remix-run#13291)
  Also fix the meta link
  ...
Copy link
Contributor

github-actions bot commented Apr 4, 2025

🤖 Hello there,

We just published version 7.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants