Skip to content

Fix middleware return types #13311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix middleware return types #13311

merged 1 commit into from
Mar 26, 2025

Conversation

brophdawg11
Copy link
Contributor

Closes #13274

Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: f336335

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Mar 26, 2025 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit efa08f6 into dev Mar 26, 2025
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/middleware-types branch March 26, 2025 21:08
Copy link
Contributor

🤖 Hello there,

We just published version 7.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

wilcoxmd added a commit to wilcoxmd/react-router that referenced this pull request Apr 3, 2025
…d-route-typegen

* upstream/dev: (56 commits)
  chore: format
  feat: unstable_subResourceIntegrity (remix-run#13163)
  Add lazy route property API, use for loading middleware (remix-run#13294)
  Add `rolldown-vite` playground (remix-run#13333)
  chore: Update version for release (remix-run#13322)
  Exit prerelease mode
  Update release notes
  Remove `react-router:override-optimize-deps` plugin (remix-run#13317)
  chore: format
  Add Wrangler v4 to `@react-router/dev` peer dep range (remix-run#13258)
  update changelog
  Handle custom base for critical CSS with Vite Env API (remix-run#13305)
  chore: Update version for release (pre) (remix-run#13312)
  Enter prerelease mode
  chore: format
  host parse (remix-run#13309)
  Fix middleware return types (remix-run#13311)
  more data docs
  fix Location link (remix-run#13291)
  Also fix the meta link
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typecheck for middleware fails when not returning response
1 participant