upgrade wrangler to v4 #13225
upgrade wrangler to v4 #13225
Conversation
* Update testing.md Without this change, the test doesn't pass * Update contributors.yml * Use destructuring Co-authored-by: Michaël De Boey <info@michaeldeboey.be> --------- Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
* fix typo * cla
* Fix typo * Update contributors.yml
|
|
Hi @matthewlynch, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
| @@ -18,8 +19,7 @@ | |||
| "serialize-javascript": "^6.0.1" | |||
| }, | |||
| "devDependencies": { | |||
| "@cloudflare/vite-plugin": "^0.1.1", | |||
| "@cloudflare/workers-types": "^4.20250214.0", | |||
There was a problem hiding this comment.
Could you also remove this from the tsconfig?
| @@ -1,5 +1,5 @@ | |||
| name = "react-router-app" | |||
| compatibility_date = "2024-11-18" | |||
| compatibility_date = "2025-03-11" | |||
There was a problem hiding this comment.
Could you make sure @cloudflare/workers-types dependencies are updated to this version too?
| }, | ||
| "peerDependencies": { | ||
| "@react-router/serve": "workspace:^", | ||
| "react-router": "workspace:^", | ||
| "typescript": "^5.1.0", | ||
| "vite": "^5.1.0 || ^6.0.0", | ||
| "wrangler": "^3.28.2" | ||
| "wrangler": "^4.0.0" |
There was a problem hiding this comment.
This should be ^3.28.2 || ^4.0.0 so it's backwards compatible.
| @@ -366,3 +366,4 @@ | |||
| - yuleicul | |||
| - zeromask1337 | |||
| - zheng-chuang | |||
| - matthewlynch | |||
There was a problem hiding this comment.
While you're here, could you sort this rather than appending it?
|
@markdalgleish i'll action these items tomorrow, thanks for the review! |
* Fix grammatical error * Update contributors.yml
|
Closing in favour of #13258 as this MR was based off of the wrong branch. |
MR superseded by #13258
wrangler typesto generate env + runtime types as per https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/CHANGELOG.md#minor-changes@cloudflare/workers-typesper the change log instructions abovecompatibility_dateto latest "2025-03-11"The generated worker-configuration.d.ts file is large and will presumably change anytime the
compatibility_dateis updated.Cloudflare are still publishing releases of
@cloudflare/workers-typesso I could update the version instead of removing it?I believe this change should be a minor version increase because the peer dependancy change is backwards compatible but please let me know.