-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples and docs to React 0.14 #901
Conversation
c576070
to
c5d615e
Compare
I'd appreciate somebody making a PR against this branch to update all the If you intend to work on this, please write a comment in this PR so we don't duplicate the effort. |
@gaearon I already updated the |
I can work on updating the rest of the docs - the only things that need to be changed are |
That's why I wrote
There are two issues in that doc commit:
|
@gaearon aah okay - I'll do that then 😄 |
These two, and removing |
Thank you! |
In I would just import |
@omnidan 👍 on what you suggested |
@gaearon alright, I updated the docs - only thing missing now are the tests. I'm too unsure about what to change there, maybe you should look into that 😅 Also somebody please have a quick look over it to make sure I didn't forget anything (I grepped for |
|
It should be |
You can remove // The child must be wrapped in a function
// to work around an issue in React 0.13. from UsageWithReact. Let's not leave traces of old API. |
@gaearon Done! I updated the other links in earlier commits (React -> ReactDOM, ReactDOMServer). Anything else, besides tests? |
This looks good to me, thank you for your help! |
This is good enough for now, so I'll merge and follow up in a second PR. |
Update examples and docs to React 0.14
Awesome! You're welcome 😁 |
Work in progress.
To be done in another PR: