Updates todo example in docs for v0.14 #865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,7 +191,8 @@ export default connect(select)(App); | |||
| #### `components/AddTodo.js` | |||
|
|
|||
| ```js | |||
| import React, { findDOMNode, Component, PropTypes } from 'react'; | |||
| import React, { Component, PropTypes } from 'react'; | |||
| import { findDOMNode } from 'react-dom'; | |||
There was a problem hiding this comment.
Instead of adding findDOMNode we can instead change the example to use the ref directly:
const node = findDOMNode(this.refs.input);becomes
const node = this.refs.input;There was a problem hiding this comment.
Thanks. Has that always worked?
npverni
force-pushed
the
todo_example_in_v0.14
branch
from
57a524f to
cd7af7c
Compare
|
I'll hold off until other PRs are ready so we can update everywhere at once. |
|
I'm closing for now as per #885. |
|
Superseded by #901. |
|
I'd appreciate some help as described in #901 (comment). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working here: https://github.com/npverni/redux-todo-example