Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert todos-with-undo being ported 0.14 #886

Merged
merged 2 commits into from
Oct 12, 2015
Merged

Revert todos-with-undo being ported 0.14 #886

merged 2 commits into from
Oct 12, 2015

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Oct 12, 2015

We will update all examples at once when everything is ready.
Please, don't send PRs to update React to 0.14: #885

Project maintainers: please don't commit updates to 0.14 to master.
cc @omnidan

gaearon added a commit that referenced this pull request Oct 12, 2015
Revert todos-with-undo being ported 0.14
@gaearon gaearon merged commit bcd084d into master Oct 12, 2015
@gaearon gaearon deleted the revert-0.14 branch October 12, 2015 19:27
@omnidan
Copy link
Contributor

omnidan commented Oct 12, 2015

Alright, sorry - didn't know we're waiting for something 😁

@gaearon
Copy link
Contributor Author

gaearon commented Oct 12, 2015

In the future it's better to create PRs. 😉 We don't want inconsistency in docs or examples, e.g. half website documenting 0.13 and half documenting 0.14.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 12, 2015

Also once we migrate to 0.14 we want examples to have no warnings. Currently DevTools, React Redux aren't ready.

@omnidan
Copy link
Contributor

omnidan commented Oct 12, 2015

@gaearon yeah that makes sense - I'll create a PR next time.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 15, 2015

Superseded by #901.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 15, 2015

I'd appreciate some help as described in #901 (comment). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants