-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds scorer to AggregateRequest #3409
adds scorer to AggregateRequest #3409
Conversation
Hi Robert, we are going to review this PR next week when @vladvildanov is back. Regards, |
Thanks @dmaier-redislabs @vladvildanov let me or Robert know if you need anything else, happy to help! Cheers. |
Pushed a isort/typing fix that should hopefully resolve CI if we could approve the workflow to see @dmaier-redislabs @vladvildanov |
@rbs333 Hi! The following tests are failing |
…3/redis-py into feat/iss-3408/add-scorer-aggregate
@vladvildanov pushed a fix for tests CI success on forked repo: https://github.com/rbs333/redis-py/actions/runs/11443317082/job/31835704097 |
@rbs333 Left a comment after detailed review |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR adds support for setting the scorer with an aggregate call and resolves issue #3408.