Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds scorer to AggregateRequest #3409

Merged
merged 8 commits into from
Oct 22, 2024
+126 −0
Merged

adds scorer to AggregateRequest #3409

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc9a866
adds scorer to AggregateRequest
rbs333 Oct 8, 2024
2172c58
fix linting
rbs333 Oct 16, 2024
a0504ea
Merge branch 'master' into feat/iss-3408/add-scorer-aggregate
vladvildanov Oct 21, 2024
4b71d01
update tests for BM25
rbs333 Oct 21, 2024
f617162
Merge branch 'feat/iss-3408/add-scorer-aggregate' of github.com:rbs33…
rbs333 Oct 21, 2024
b28656d
enum for aggregation scorer
rbs333 Oct 22, 2024
5e1cadb
update signature
rbs333 Oct 22, 2024
bb95f1c
revert back to string input
rbs333 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update signature
  • Loading branch information
@rbs333
rbs333 committed Oct 22, 2024
commit 5e1cadbf24c4e81130d46b3d0ed53f85399dd56a
2 changes: 1 addition & 1 deletion redis/commands/search/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def add_scores(self) -> "AggregateRequest":
self._add_scores = True
return self

def scorer(self, scorer: str) -> "AggregateRequest":
def scorer(self, scorer: Scorers) -> "AggregateRequest":
"""
Use a different scoring function to evaluate document relevance.
Default is `TFIDF`.
Expand Down
Loading