[ci] Remove outside any set, as not much valueable (#5998)

* [ci] Remove outside any set, as not much valueable

* remove fixed error

* remove nette/robot-loader

composer-dependency-analyser.php

@@ -9,12 +9,10 @@
 
 return $config
     ->addPathToScan(__DIR__ . '/build/config', false)
-    ->ignoreErrorsOnPackage('phpunit/phpunit', [ErrorType::DEV_DEPENDENCY_IN_PROD]) // prepared test tooling
-    ->ignoreErrorsOnPackage('react/promise', [ErrorType::UNUSED_DEPENDENCY]) // pinned v3.x version
-    ->ignoreErrorsOnPackage(
-        'nette/robot-loader',
-        [ErrorType::DEV_DEPENDENCY_IN_PROD]
-    ) // https://github.com/rectorphp/rector-src/pull/5777#discussion_r1541304301
+    // prepared test tooling
+    ->ignoreErrorsOnPackage('phpunit/phpunit', [ErrorType::DEV_DEPENDENCY_IN_PROD])
+    // pinned v3.x version
+    ->ignoreErrorsOnPackage('react/promise', [ErrorType::UNUSED_DEPENDENCY])
     ->ignoreErrorsOnPaths([
         __DIR__ . '/stubs',
         __DIR__ . '/tests',

composer.json

@@ -42,7 +42,6 @@
         "webmozart/assert": "^1.11"
     },
     "require-dev": {
-        "nette/robot-loader": "^4.0",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan-phpunit": "^1.4",
         "phpstan/phpstan-webmozart-assert": "^1.2.6",

phpstan.neon

@@ -143,7 +143,6 @@ parameters:
                 - bin/rector.php
                 # for config class reflection
                 - src/Bootstrap/ExtensionConfigResolver.php
-                - src/DependencyInjection/LazyContainerFactory.php
                 - src/Validation/RectorConfigValidator.php
 
         # use of internal phpstan classes

src/Config/Level/DeadCodeLevel.php

@@ -13,6 +13,7 @@
 use Rector\DeadCode\Rector\Cast\RecastingRemovalRector;
 use Rector\DeadCode\Rector\ClassConst\RemoveUnusedPrivateClassConstantRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveNullTagValueNodeRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
@@ -71,6 +72,7 @@ final class DeadCodeLevel
      */
     public const RULES = [
         // easy picks
+        RemoveNullTagValueNodeRector::class,
         RemoveUnusedForeachKeyRector::class,
         RemoveDuplicatedArrayKeyRector::class,
         RecastingRemovalRector::class,

src/DependencyInjection/LazyContainerFactory.php

@@ -180,7 +180,6 @@
 use Rector\StaticTypeMapper\PhpParser\StringNodeMapper;
 use Rector\StaticTypeMapper\PhpParser\UnionTypeNodeMapper;
 use Rector\StaticTypeMapper\StaticTypeMapper;
-use Rector\Utils\Command\OutsideAnySetCommand;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Style\SymfonyStyle;
@@ -419,11 +418,6 @@ public function create(): RectorConfig
             ->needs('$rectors')
             ->giveTagged(RectorInterface::class);
 
-        // dev
-        if (class_exists(OutsideAnySetCommand::class)) {
-            $rectorConfig->singleton(OutsideAnySetCommand::class);
-        }
-
         $rectorConfig->singleton(FileProcessor::class);
         $rectorConfig->singleton(PostFileProcessor::class);