Skip to content

Commit

Permalink
[ci] Remove missing-in-set as too robust, set are not bound to namesp…
Browse files Browse the repository at this point in the history
…ace (#5997)
  • Loading branch information
TomasVotruba authored Jun 21, 2024
1 parent c47a255 commit 69c35a5
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 213 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/code_analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ jobs:
name: 'Compatible PHPStan versions'
run: php bin/validate-phpstan-version.php

-
name: 'Detect Rules Missing in Set'
run: bin/rector missing-in-set --ansi

# see https://github.com/rectorphp/rector-generator
-
name: 'Rector Generate From Recipe'
Expand Down
4 changes: 1 addition & 3 deletions src/DependencyInjection/LazyContainerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@
use Rector\StaticTypeMapper\PhpParser\StringNodeMapper;
use Rector\StaticTypeMapper\PhpParser\UnionTypeNodeMapper;
use Rector\StaticTypeMapper\StaticTypeMapper;
use Rector\Utils\Command\MissingInSetCommand;
use Rector\Utils\Command\OutsideAnySetCommand;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Command\Command;
Expand Down Expand Up @@ -421,8 +420,7 @@ public function create(): RectorConfig
->giveTagged(RectorInterface::class);

// dev
if (class_exists(MissingInSetCommand::class)) {
$rectorConfig->singleton(MissingInSetCommand::class);
if (class_exists(OutsideAnySetCommand::class)) {
$rectorConfig->singleton(OutsideAnySetCommand::class);
}

Expand Down
124 changes: 0 additions & 124 deletions utils/Command/MissingInSetCommand.php

This file was deleted.

82 changes: 0 additions & 82 deletions utils/Enum/RectorDirectoryToSetFileMap.php

This file was deleted.

0 comments on commit 69c35a5

Please sign in to comment.