Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove outside any set, as not much valueable #5998

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

TomasVotruba
Copy link
Member

  • [ci] Remove outside any set, as not much valueable
  • remove fixed error

@TomasVotruba TomasVotruba changed the title tv ci checks 2 [ci] Remove outside any set, as not much valueable Jun 21, 2024
@TomasVotruba TomasVotruba merged commit 676bb07 into main Jun 21, 2024
37 checks passed
@TomasVotruba TomasVotruba deleted the tv-ci-checks-2 branch June 21, 2024 13:38
@@ -71,6 +72,7 @@ final class DeadCodeLevel
*/
public const RULES = [
// easy picks
RemoveNullTagValueNodeRector::class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasVotruba I think this should be on the last instead of first if needed to be added into set, that have save belt on RemveUseless*TagRector already, see PR:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants