Skip to content

feat: Add new TableHeaderCell#726

Merged
kurtdoherty merged 1 commit intomainfrom
feat-add-table-header-cell
Aug 28, 2025
Merged

feat: Add new TableHeaderCell#726
kurtdoherty merged 1 commit intomainfrom
feat-add-table-header-cell

Conversation

@kurtdoherty
Copy link
Contributor

@kurtdoherty kurtdoherty commented Aug 28, 2025

Context

This PR

  • Adds TableHeaderCell.
Screenshot 2025-08-29 at 8 36 54 am Screenshot 2025-08-29 at 8 37 01 am Screenshot 2025-08-29 at 8 37 05 am

@rpt-uk-github
Copy link

rpt-uk-github commented Aug 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty force-pushed the feat-add-table-header-cell branch from 043f5dc to 60116b7 Compare August 28, 2025 22:38
@codacy-production
Copy link

codacy-production bot commented Aug 28, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9b903791 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9b90379) Report Missing Report Missing Report Missing
Head commit (a7f92d1) 8525 7886 92.50%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#726) 17 17 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty force-pushed the feat-add-table-header-cell branch from 60116b7 to a7f92d1 Compare August 28, 2025 22:49
@@ -17,6 +17,12 @@ export function buildTableWrapper(placement: ChildPlacement): FC<{ children: Rea
width: '100%',
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: need these temporarily while the proper header row and table head components are built

@kurtdoherty kurtdoherty marked this pull request as ready for review August 28, 2025 22:56
@kurtdoherty kurtdoherty merged commit 79c9d1e into main Aug 28, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-add-table-header-cell branch August 28, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants