Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
e812446 to
bc42b19
Compare
| @@ -0,0 +1,41 @@ | |||
| export type SortDirection = 'ascending' | 'descending' | 'none' | |||
|
|
|||
There was a problem hiding this comment.
note: some or all of this may move to a component-agnostic place in future (e.g., perhaps utils). In particular, when we have our search params schema implemented, we'll likely want a sort param schema to help us serialise and parse sort fields and directions to and from the URL.
Context
@reapit/elements/lab/table, but these don't facilitate the level of nuance required by the DS. For example:td,trand so on, but we may need the flexibility of using them in a div-based DOM structure instead.@reapit/elements/core/table.TableRowPrimaryAction#715, feat: Add newTableCellPrimaryData#716, feat: Add newTableCellDoubleLineLayout#717, feat: Add newTableBodyCell#718, feat: Add newTableBodyRow#719 and feat: Add newTableBody#720.This PR
TableCellSortButton.