Skip to content

feat: Add new TableBodyCell#718

Merged
kurtdoherty merged 1 commit intomainfrom
feat-add-table-body-cell
Aug 27, 2025
Merged

feat: Add new TableBodyCell#718
kurtdoherty merged 1 commit intomainfrom
feat-add-table-body-cell

Conversation

@kurtdoherty
Copy link
Contributor

Context

  • We have table atoms in @reapit/elements/lab/table, but these don't facilitate the level of nuance required by the DS. For example:
    • They are pinned to semantic table elements like td, tr and so on, but we may need the flexibility of using them in a div-based DOM structure instead.
    • They do not provide any solution for the primary row action (which is meant to appear like the row itself is interactive).
    • They do not provide any solution for rendering row header cells.
    • They require column widths to be defined at the cell-level of the table rather than once at the table-level.
  • We want to enhance the capability of our table atoms when implementing "official" core versions of them (i.e. the table atoms that will be available via @reapit/elements/core/table.
  • The first chunk of this work will be done over a number of PRs and be focused on atoms involved in the table's body:

This PR

  • Adds TableBodyCell. This component handles the layout requirements of the actual cell within the table's body (classically, the <td> and <th> elements).
Screenshot 2025-08-27 at 12 57 43 pm Screenshot 2025-08-27 at 12 57 49 pm Screenshot 2025-08-27 at 12 57 57 pm Screenshot 2025-08-27 at 12 58 02 pm

@rpt-uk-github
Copy link

rpt-uk-github commented Aug 27, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty marked this pull request as ready for review August 27, 2025 03:00
@codacy-production
Copy link

codacy-production bot commented Aug 27, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 846e0cf1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (846e0cf) Report Missing Report Missing Report Missing
Head commit (15055f5) 8397 7761 92.43%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#718) 16 16 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty force-pushed the feat-add-table-body-cell branch 2 times, most recently from f5c97b4 to b89955c Compare August 27, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants