test migration: session tests #5391

JacobOscarGunnarsson · 2023-02-08T10:44:17Z

This file is also quite big meaning that there's probably a lot of tests that could be moved to separate files, I've decided to postpone it for now and focus more on just moving the tests

CHANGELOG.md

integration-tests/tests/src/tests/queries.ts

JacobOscarGunnarsson · 2023-02-10T13:18:34Z

PR should now contain the correct modifications 🤞

integration-tests/tests/src/tests/sync/sync-session.ts

integration-tests/realm-apps/with-db/services/mongodb/config.json

integration-tests/tests/src/utils/sleep.ts

kraenhansen · 2023-02-14T14:02:06Z

integration-tests/tests/src/tests/sync/sync-session.ts

+        new Promise(() => {
+          sleep(5000, false);
+        }),


No need to wrap this in a promise constructor.
Also, since the callback body is neither awaiting nor returning the promise, this is effectively a promise that never resolves but calls sleep which might become an unhandled promise rejection.

Suggested change

new Promise(() => {

sleep(5000, false);

}),

sleep(5000, false),

integration-tests/tests/src/tests/sync/sync-session.ts

takameyer

A few considerations. Once resolved, LGTM

integration-tests/tests/src/tests/sync/sync-session.ts

integration-tests/tests/src/utils/sleep.ts

Co-authored-by: Gagik Amaryan <gagik@users.noreply.github.com>

gagik · 2023-02-16T11:28:30Z

integration-tests/tests/src/tests/sync/realm-conversions.ts

+    }
+
+    afterEach(async function (this: AppContext & ConversionTestContext) {
+      const configSrc = this.currentTest?.ctx?.configSrc;


Not sure if there is a better way to retrieve this information / accomplish this cleanup... this seems like a rather ugly way to do so... but it does work.

Co-authored-by: Gagik Amaryan <gagik@users.noreply.github.com> Co-authored-by: gagik <me@gagik.co>

* Initial commit * Documenting guidelines for testing & refactoring accordingly (#4584) * Fixed types of openRealm * Adding documentation on the hooks * Apply suggestions from code review * Test Migration: Alias tests (#4581) * Migrate alias tests * Refactor to follow new test guidelines * Remove alias-tests from legacy test spec * Add migration tests (#5285) * Migrate set tests to integration tests (#5290) * Move list tests to ts (#5287) * move app tests to typescript (#5297) * remove mistakenly added duplicates of apps * Test Migration: Results Tests (#5325) * move mixed tests to integration tests (#5256) * Move array-buffer tests to integration tests (#5255) * use correct baseurl for tests (#5337) * migrate dictionary tests to ts (#5254) * move linking-objects tests to ts (#5268) * Test Migration: User Tests (#5324) * Test Migration: Queries test (#5299) * Test Migration: Notification Tests (#5347) * Add a debug launcher for integration tests * Fix the mongo client tests for local baas * fix queries test, make test errors more verbose * Remove Chrome Debugger and fix package-lock problems (#5403) * Pushed Chrome Debugger Removal with Lint errors (#5414) * fix the errors * Andrew/tests/fix-watch (#5412) * Initial commit * Fix watch for React Native * Remove lock files * Migrate object-tests to TS (#5348) * test migration: open-behaviour (#5365) * test migration: mixed-sync-test (#5398) * migrate encryption tests to TS (#5362) * migrate sync-based UUID, Dictionary and Set tests (#5356) * migrate realm tests to TS (#5352) there are additions to other files as well such as bson.ts, that is because the old realm.js file had som tests that made more sense elsewhere, so I've moved such tests into other fields where I thought it made more sense * migrate partition-values tests to TS (#5359) * test migration: session tests (#5391) * Fix issues with migrated integration tests, add select helper method. (#5429) * Refactored the importApp hook * Remove BSON as a dependency from tests * Fixed import app hook 🤞 * Renamed "BackingDB" to "mongodb" * Throw on app import errors * Delete the app on failure to import * Added bundled Realm to iOS app * Updating Gemfile.lock after RN update * Increase test timeouts * fix remainder of failing integration tests (#5451) * Cleanup tests and move test-runners into install-tests * Small Fixes for Stability and Cleanup * path tests now put realms in a testFiles folder which has been added to .gitignore * path tests now delete the realms when finished * increased the longTimeout to 30 seconds as some of the migrated tests can take this long * added more `this.longTimeout` calls where appropriate * added `mongodb-realm` directory to .gitignore, which contains app configuration when importing apps * Delete dependants of `tests` and any unused files * Andrew/app-importer/rules (#5478) * Fix for applying the default rules to BaaS * Remove any other rules and apply a general rule that allows everything * Change the app importer to update the default rule * Also fix it for realm-web * Fix web tests and apply PR feedback * Update docker image for BaaS in web tests * `realm-web` importing http service fixed (#5483) * Use the "default_rule" only for mongodb services * Ensure download assisted_agg in baas test server * Fix a broken test from upgrading baas

kraenhansen · 2023-02-27T14:27:40Z

tests/js/session-tests.js

-  testAddConnectionNotification() {
-    const partition = Utils.genPartition();
-    let app = new Realm.App(appConfig);
-    const credentials = Realm.Credentials.anonymous();
-    return app
-      .logIn(credentials)
-      .then((u) => {
-        let config = getSyncConfiguration(u, partition);
-        return Realm.open(config);
-      })
-      .then((realm) => {
-        return new Promise((resolve, reject) => {
-          realm.syncSession.addConnectionNotification((newState, oldState) => {
-            if (
-              oldState === Realm.App.Sync.ConnectionState.Connected &&
-              newState === Realm.App.Sync.ConnectionState.Disconnected
-            ) {
-              resolve();
-            }
-          });
-          realm.close();
-        });
-      });
-  },


@JacobOscarGunnarsson this seems to be missing from the migrated tests.

Or is it this? https://github.com/realm/realm-js/pull/5391/files#diff-0ab9adc1bbb7aee926da3074f9a75569f592434ba0585601cb9321ff5410a7d6R383-R404

JacobOscarGunnarsson requested review from takameyer and kraenhansen February 8, 2023 10:44

cla-bot bot added the cla: yes label Feb 8, 2023

takameyer force-pushed the test-migration-master branch from 3112736 to c8de9df Compare February 8, 2023 14:32

takameyer force-pushed the jg/session-master branch from cbb1ad4 to 6e58179 Compare February 8, 2023 14:40

kraenhansen reviewed Feb 9, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

kraenhansen reviewed Feb 9, 2023

View reviewed changes

integration-tests/tests/src/tests/queries.ts Outdated Show resolved Hide resolved

takameyer force-pushed the test-migration-master branch 2 times, most recently from fa6d1fc to cea05ef Compare February 10, 2023 09:49

gagik force-pushed the jg/session-master branch 2 times, most recently from a5f536f to 92dae35 Compare February 10, 2023 11:00

JacobOscarGunnarsson requested a review from kraenhansen February 10, 2023 13:18

takameyer approved these changes Feb 10, 2023

View reviewed changes

JacobOscarGunnarsson force-pushed the jg/session-master branch from af83012 to 466d286 Compare February 13, 2023 07:53

kraenhansen approved these changes Feb 13, 2023

View reviewed changes

JacobOscarGunnarsson force-pushed the jg/session-master branch from 7014cf4 to 5bd19b0 Compare February 14, 2023 10:47

Jacob Gunnarsson added 13 commits February 14, 2023 11:49

add session test file

751b22d

add initial tests covering invalid syncsessions

00230ab

rename file

4e13bcd

required tests pass

7dad1fc

removed no longer used file

13b9314

minor refactoring

5edf475

formatting

ccb05f7

add hooks

8c95652

remove legacy file

0566140

remove partition return type from functions, get rid of unused variables

2ed427e

remove legacy requirement of session-tests

12c3b19

fix package lock

dc6b7bd

fixed bug of last test

0ee1d10

JacobOscarGunnarsson force-pushed the jg/session-master branch from 5bd19b0 to 0ee1d10 Compare February 14, 2023 10:59

JacobOscarGunnarsson commented Feb 14, 2023

View reviewed changes

integration-tests/tests/src/tests/sync/sync-session.ts Show resolved Hide resolved

JacobOscarGunnarsson commented Feb 14, 2023

View reviewed changes

integration-tests/tests/src/tests/sync/sync-session.ts Show resolved Hide resolved

JacobOscarGunnarsson requested review from takameyer and kraenhansen February 14, 2023 11:17

kraenhansen reviewed Feb 14, 2023

View reviewed changes

fix pr comments

7c1b9ed

JacobOscarGunnarsson requested a review from kraenhansen February 14, 2023 16:32

takameyer approved these changes Feb 15, 2023

View reviewed changes

Jacob Gunnarsson and others added 5 commits February 15, 2023 13:26

move parition value realted tests to correct file

c18bf50

rename timeout helper method

ac2c572

refactoring

8c262a3

Co-authored-by: Gagik Amaryan <gagik@users.noreply.github.com>

Temp

4929f87

Refactor conversion tests.

68a2d0f

gagik reviewed Feb 16, 2023

View reviewed changes

Add more documentation

4ea628f

gagik requested a review from takameyer February 16, 2023 11:33

skip realm-conversions until tests are migrated

278cd16

JacobOscarGunnarsson merged commit 9dd0f28 into test-migration-master Feb 17, 2023

JacobOscarGunnarsson deleted the jg/session-master branch February 17, 2023 08:35

kraenhansen pushed a commit that referenced this pull request Feb 17, 2023

test migration: session tests (#5391)

b554d22

Co-authored-by: Gagik Amaryan <gagik@users.noreply.github.com> Co-authored-by: gagik <me@gagik.co>

kraenhansen reviewed Feb 27, 2023

View reviewed changes

github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test migration: session tests #5391

test migration: session tests #5391

JacobOscarGunnarsson commented Feb 8, 2023

JacobOscarGunnarsson commented Feb 10, 2023

kraenhansen Feb 14, 2023

takameyer left a comment

gagik Feb 16, 2023 •

edited

Loading

kraenhansen Feb 27, 2023

kraenhansen Feb 27, 2023

test migration: session tests #5391

test migration: session tests #5391

Conversation

JacobOscarGunnarsson commented Feb 8, 2023

JacobOscarGunnarsson commented Feb 10, 2023

kraenhansen Feb 14, 2023

Choose a reason for hiding this comment

takameyer left a comment

Choose a reason for hiding this comment

gagik Feb 16, 2023 • edited Loading

Choose a reason for hiding this comment

kraenhansen Feb 27, 2023

Choose a reason for hiding this comment

kraenhansen Feb 27, 2023

Choose a reason for hiding this comment

gagik Feb 16, 2023 •

edited

Loading