move app tests to typescript #5297

JacobOscarGunnarsson · 2023-01-20T14:07:25Z

No description provided.

takameyer

Just a couple small things. Otherwise LGTM

integration-tests/tests/src/tests/sync/app.ts

takameyer · 2023-01-23T12:02:30Z

integration-tests/tests/src/tests/sync/app.ts

+      expect(this.app).instanceOf(Realm.App);
+      const credentials = Realm.Credentials.emailPassword("me", "secret");
+      let didFail = false;
+      const user = await this.app.logIn(credentials).catch((err) => {


This could be refactored to use expect().to.throw()

That only works for synchronously thrown errors - we should use expect().should.be.rejectedWith() to assert rejection of promises. That being said, I don't think that'll be able to replace this code entirely as it's not simply matching on the error message, but also asserts the code to be 50 🤔

integration-tests/tests/src/tests/sync/app.ts

kraenhansen

I have only minor suggestions.

integration-tests/tests/src/tests/sync/app.ts

kraenhansen · 2023-01-23T12:19:57Z

integration-tests/tests/src/tests/sync/app.ts

+      let failed = false;
+      await app.logIn(credentials).catch((err) => {
+        failed = true;
+        expect(err.message).equals("cannot find app using Client App ID 'smurf'");
+      });
+      expect(failed).to.be.true;


Same as with previous test - chai-as-promised is "the way" to assert promise rejections.

kraenhansen · 2023-01-23T12:22:03Z

integration-tests/tests/src/tests/sync/app.ts

+      expect(user).instanceOf(Realm.User);
+      expect(user.deviceId).to.not.be.null;
+      expect(user.providerType).equals("anon-user");
+      await user.logOut();


I know the old test did this, but is it important? if not, it could be deleted. If yes, it might be better to do in an afterEach or surround the other parts of this test in a try-finally, where we ensure to log out, even if the code throws.

kraenhansen · 2023-01-23T12:24:18Z

integration-tests/tests/src/tests/sync/app.ts

+      expect(this.app).instanceOf(Realm.App);
+      const credentials = Realm.Credentials.emailPassword("me", "secret");
+      let didFail = false;
+      const user = await this.app.logIn(credentials).catch((err) => {


That only works for synchronously thrown errors - we should use expect().should.be.rejectedWith() to assert rejection of promises. That being said, I don't think that'll be able to replace this code entirely as it's not simply matching on the error message, but also asserts the code to be 50 🤔

integration-tests/realm-apps/with-db/auth_providers/local-userpass.json

integration-tests/tests/src/tests/sync/app.ts

integration-tests/tests/src/utils/generators.ts

* Initial commit * Documenting guidelines for testing & refactoring accordingly (#4584) * Fixed types of openRealm * Adding documentation on the hooks * Apply suggestions from code review * Test Migration: Alias tests (#4581) * Migrate alias tests * Refactor to follow new test guidelines * Remove alias-tests from legacy test spec * Add migration tests (#5285) * Migrate set tests to integration tests (#5290) * Move list tests to ts (#5287) * move app tests to typescript (#5297) * remove mistakenly added duplicates of apps * Test Migration: Results Tests (#5325) * move mixed tests to integration tests (#5256) * Move array-buffer tests to integration tests (#5255) * use correct baseurl for tests (#5337) * migrate dictionary tests to ts (#5254) * move linking-objects tests to ts (#5268) * Test Migration: User Tests (#5324) * Test Migration: Queries test (#5299) * Test Migration: Notification Tests (#5347) * Add a debug launcher for integration tests * Fix the mongo client tests for local baas * fix queries test, make test errors more verbose * Remove Chrome Debugger and fix package-lock problems (#5403) * Pushed Chrome Debugger Removal with Lint errors (#5414) * fix the errors * Andrew/tests/fix-watch (#5412) * Initial commit * Fix watch for React Native * Remove lock files * Migrate object-tests to TS (#5348) * test migration: open-behaviour (#5365) * test migration: mixed-sync-test (#5398) * migrate encryption tests to TS (#5362) * migrate sync-based UUID, Dictionary and Set tests (#5356) * migrate realm tests to TS (#5352) there are additions to other files as well such as bson.ts, that is because the old realm.js file had som tests that made more sense elsewhere, so I've moved such tests into other fields where I thought it made more sense * migrate partition-values tests to TS (#5359) * test migration: session tests (#5391) * Fix issues with migrated integration tests, add select helper method. (#5429) * Refactored the importApp hook * Remove BSON as a dependency from tests * Fixed import app hook 🤞 * Renamed "BackingDB" to "mongodb" * Throw on app import errors * Delete the app on failure to import * Added bundled Realm to iOS app * Updating Gemfile.lock after RN update * Increase test timeouts * fix remainder of failing integration tests (#5451) * Cleanup tests and move test-runners into install-tests * Small Fixes for Stability and Cleanup * path tests now put realms in a testFiles folder which has been added to .gitignore * path tests now delete the realms when finished * increased the longTimeout to 30 seconds as some of the migrated tests can take this long * added more `this.longTimeout` calls where appropriate * added `mongodb-realm` directory to .gitignore, which contains app configuration when importing apps * Delete dependants of `tests` and any unused files * Andrew/app-importer/rules (#5478) * Fix for applying the default rules to BaaS * Remove any other rules and apply a general rule that allows everything * Change the app importer to update the default rule * Also fix it for realm-web * Fix web tests and apply PR feedback * Update docker image for BaaS in web tests * `realm-web` importing http service fixed (#5483) * Use the "default_rule" only for mongodb services * Ensure download assisted_agg in baas test server * Fix a broken test from upgrading baas

JacobOscarGunnarsson requested review from takameyer and kraenhansen January 20, 2023 14:07

cla-bot bot added the cla: yes label Jan 20, 2023

takameyer approved these changes Jan 23, 2023

View reviewed changes

kraenhansen reviewed Jan 23, 2023

View reviewed changes

integration-tests/tests/src/tests/sync/app.ts Outdated Show resolved Hide resolved

kraenhansen approved these changes Jan 23, 2023

View reviewed changes

Jacob Gunnarsson and others added 7 commits January 24, 2023 14:40

tmp while waiting for reply about mock app

a2ca3d9

Refactor importApp to not instantiate a Realm.App

22117aa

tmp

d2e847e

move app tests to typescript

2ab6c0d

reset state of realm apps

a3f5643

add bindgen Apps

beef68d

redo tests to use bindgen apps

b3eb27f

JacobOscarGunnarsson force-pushed the jg/app-master branch from 11f472a to b3eb27f Compare January 24, 2023 13:40

Jacob Gunnarsson added 2 commits January 24, 2023 15:12

fix pr comments

326346d

remove legacy app tests

4cae023

JacobOscarGunnarsson merged commit e7f0d99 into test-migration-master Jan 24, 2023

JacobOscarGunnarsson deleted the jg/app-master branch January 24, 2023 15:21

takameyer pushed a commit that referenced this pull request Feb 8, 2023

move app tests to typescript (#5297)

ad5272c

takameyer pushed a commit that referenced this pull request Feb 10, 2023

move app tests to typescript (#5297)

2de2dc6

takameyer pushed a commit that referenced this pull request Feb 10, 2023

move app tests to typescript (#5297)

0ed1c6f

kraenhansen pushed a commit that referenced this pull request Feb 17, 2023

move app tests to typescript (#5297)

5bf70db

github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move app tests to typescript #5297

move app tests to typescript #5297

JacobOscarGunnarsson commented Jan 20, 2023

takameyer left a comment

takameyer Jan 23, 2023

kraenhansen Jan 23, 2023

kraenhansen left a comment

kraenhansen Jan 23, 2023

kraenhansen Jan 23, 2023

kraenhansen Jan 23, 2023

move app tests to typescript #5297

move app tests to typescript #5297

Conversation

JacobOscarGunnarsson commented Jan 20, 2023

takameyer left a comment

Choose a reason for hiding this comment

takameyer Jan 23, 2023

Choose a reason for hiding this comment

kraenhansen Jan 23, 2023

Choose a reason for hiding this comment

kraenhansen left a comment

Choose a reason for hiding this comment

kraenhansen Jan 23, 2023

Choose a reason for hiding this comment

kraenhansen Jan 23, 2023

Choose a reason for hiding this comment

kraenhansen Jan 23, 2023

Choose a reason for hiding this comment