Migrate migration tests to integration tests #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Jan 18, 2023
gagik
commented
Jan 18, 2023
| const TestSchema = { | ||
| name: "Test", | ||
| properties: { | ||
| prop0: "string", |
There was a problem hiding this comment.
I am not a huge fan of this prop0, prop1 naming I just kept it to make conversion quicker, but maybe I could adapt it to existing schemas. IMO it'd be good to have an extremely simple schema like this shared, as existing Person/Dog and Playlist/Song all have more complex things like relationships.
There was a problem hiding this comment.
At least in tests, I wouldn't want to make a shared schema as this creates coupling between test suites. I would like to avoid this, as when one needs to expand on the shared schema, it effects unrelated tests and could lead to unintended failures.
I do agree though, that the property names could be improved.
There was a problem hiding this comment.
I am changing prop0 => name, prop1 => age, prop2 => surname
takameyer
approved these changes
Jan 18, 2023
| const TestSchema = { | ||
| name: "Test", | ||
| properties: { | ||
| prop0: "string", |
There was a problem hiding this comment.
At least in tests, I wouldn't want to make a shared schema as this creates coupling between test suites. I would like to avoid this, as when one needs to expand on the shared schema, it effects unrelated tests and could lead to unintended failures.
I do agree though, that the property names could be improved.
takameyer
pushed a commit
that referenced
this pull request
Feb 8, 2023
takameyer
pushed a commit
that referenced
this pull request
Feb 10, 2023
takameyer
pushed a commit
that referenced
this pull request
Feb 10, 2023
kraenhansen
pushed a commit
that referenced
this pull request
Feb 17, 2023
takameyer
added a commit
that referenced
this pull request
Feb 23, 2023
* Initial commit * Documenting guidelines for testing & refactoring accordingly (#4584) * Fixed types of openRealm * Adding documentation on the hooks * Apply suggestions from code review * Test Migration: Alias tests (#4581) * Migrate alias tests * Refactor to follow new test guidelines * Remove alias-tests from legacy test spec * Add migration tests (#5285) * Migrate set tests to integration tests (#5290) * Move list tests to ts (#5287) * move app tests to typescript (#5297) * remove mistakenly added duplicates of apps * Test Migration: Results Tests (#5325) * move mixed tests to integration tests (#5256) * Move array-buffer tests to integration tests (#5255) * use correct baseurl for tests (#5337) * migrate dictionary tests to ts (#5254) * move linking-objects tests to ts (#5268) * Test Migration: User Tests (#5324) * Test Migration: Queries test (#5299) * Test Migration: Notification Tests (#5347) * Add a debug launcher for integration tests * Fix the mongo client tests for local baas * fix queries test, make test errors more verbose * Remove Chrome Debugger and fix package-lock problems (#5403) * Pushed Chrome Debugger Removal with Lint errors (#5414) * fix the errors * Andrew/tests/fix-watch (#5412) * Initial commit * Fix watch for React Native * Remove lock files * Migrate object-tests to TS (#5348) * test migration: open-behaviour (#5365) * test migration: mixed-sync-test (#5398) * migrate encryption tests to TS (#5362) * migrate sync-based UUID, Dictionary and Set tests (#5356) * migrate realm tests to TS (#5352) there are additions to other files as well such as bson.ts, that is because the old realm.js file had som tests that made more sense elsewhere, so I've moved such tests into other fields where I thought it made more sense * migrate partition-values tests to TS (#5359) * test migration: session tests (#5391) * Fix issues with migrated integration tests, add select helper method. (#5429) * Refactored the importApp hook * Remove BSON as a dependency from tests * Fixed import app hook 🤞 * Renamed "BackingDB" to "mongodb" * Throw on app import errors * Delete the app on failure to import * Added bundled Realm to iOS app * Updating Gemfile.lock after RN update * Increase test timeouts * fix remainder of failing integration tests (#5451) * Cleanup tests and move test-runners into install-tests * Small Fixes for Stability and Cleanup * path tests now put realms in a testFiles folder which has been added to .gitignore * path tests now delete the realms when finished * increased the longTimeout to 30 seconds as some of the migrated tests can take this long * added more `this.longTimeout` calls where appropriate * added `mongodb-realm` directory to .gitignore, which contains app configuration when importing apps * Delete dependants of `tests` and any unused files * Andrew/app-importer/rules (#5478) * Fix for applying the default rules to BaaS * Remove any other rules and apply a general rule that allows everything * Change the app importer to update the default rule * Also fix it for realm-web * Fix web tests and apply PR feedback * Update docker image for BaaS in web tests * `realm-web` importing http service fixed (#5483) * Use the "default_rule" only for mongodb services * Ensure download assisted_agg in baas test server * Fix a broken test from upgrading baas
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A migration of migration tests.