New 0.62.0 changelog #166

kelset · 2020-03-03T17:24:14Z

Allright, this is the new version of #156 that uses the new improved script (thanks @alloy!).

As we can clearly see, now the number of changes is quite more massive than the one we saw in the previous one... which means that in the ballpack number of 1.2k commits around 60-ish percent are not FB internals.

But there are still quite a big number of "unknowns" to put in the right place... I don't have time to do it atm but I'm starting to open this as a draft PR.

RELEVANT LOGS from the command:

Unable to find differential revisions for the following commits. If these were made on the release branch only, be sure to update the CHANGELOG entries to point to the commit on the master branch after back-porting.
    https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064
    https://github.com/facebook/react-native/commit/26e7d6a06211412a079af746750c5dd9edbfecbb
    https://github.com/facebook/react-native/commit/cef001713fc6384353bbcb4d45645ceee44ed1a9
    https://github.com/facebook/react-native/commit/99ef72cad73da25d76bf8177272724cfe6cece61
    https://github.com/facebook/react-native/commit/55276a9b104781b49b66938d71aac385bdd236e5

and

Unable to find differential revisions for the following commits. If these were made on the release branch only, be sure to update the CHANGELOG entries to point to the commit on the master branch after back-porting.
    https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064
    https://github.com/facebook/react-native/commit/26e7d6a06211412a079af746750c5dd9edbfecbb
    https://github.com/facebook/react-native/commit/cef001713fc6384353bbcb4d45645ceee44ed1a9
    https://github.com/facebook/react-native/commit/99ef72cad73da25d76bf8177272724cfe6cece61
    https://github.com/facebook/react-native/commit/55276a9b104781b49b66938d71aac385bdd236e5

jeremy-deutsch · 2020-03-03T18:04:36Z

I'd like to help sort the "unknowns". @kelset, would it be possible for you to give someone trusted (like @alloy) edit access to this branch/PR, so that you don't have to be the only person who approves suggestions/moves around the "unknowns"?

elicwhite · 2020-03-03T18:45:15Z

Can we get the unknown ones grouped by user? Almost all of those are Facebook employees, so we can just ask them to write the changelog for those commits.

CHANGELOG.md

jeremy-deutsch · 2020-03-03T19:02:53Z

It looks like GitHub's having some issues (note the quoted section of the changelog):

alloy · 2020-03-03T19:04:12Z

@TheSavior As a one-off, for just this version, we can sort those sections with sort -f -t @ -k 2. E.g. on macOS, copy the entries of an unknown section and then run:

pbpaste | sort -f -t @ -k 2 | pbcopy

…and paste it back.

EDIT: I’ll do this after figuring out the issues @TheSavior identified, because running it now would just lead to even weirder sort results.

CHANGELOG.md

alloy · 2020-03-03T19:16:22Z

Btw, we should probably only fix the unknown entries once we generate the changelog for the version we agree to release as stable version, right? Then people can just PR their fixed changelog entries onto this branch.

CHANGELOG.md

kelset · 2020-03-04T08:35:47Z

re: @jeremy-deutsch

I'd like to help sort the "unknowns". @kelset, would it be possible for you to give someone trusted (like @alloy) edit access to this branch/PR, so that you don't have to be the only person who approves suggestions/moves around the "unknowns"?

Eloy has write access to this repo so he can "take over" this branch when/if he wants :)
As do all the members of the RNComm github org, since it's the default setting to have write access to all repos.

I don't think I will have time to work on the feedback here today - so if anyone is taking it over please just write a comment when they do and when they are done so that we are all aware 🤗

alloy · 2020-03-06T23:44:55Z

@TheSavior Updated based on RC4 and sorted the unknowns by author.

elicwhite · 2020-03-07T00:14:44Z

Yay! Thanks

Do you think this is likely to be the one and we should get our team to start annotating the uncategorized commits? Or should we hold off?

alloy · 2020-03-07T00:19:00Z

I’d like for this to be the one, so yeah ready to get started 👍

jeremy-deutsch

Just did a quick scan over the "added" section and noted some things that might not belong in there.

CHANGELOG.md

rickhanlonii · 2020-03-18T01:59:43Z

@kelset do you want to review the suggested changes and I'll take a pass after that?

elicwhite · 2020-03-18T03:59:29Z

@rickhanlonii, I think there was talk of someone just making changes and committing back to this branch. Do you have access?

I imagine that is easier than flagging 100 commits as internal for someone else to remove :-)

alloy · 2020-03-18T19:42:20Z

@jeremy-deutsch Hiya! You seem interested in helping out with the CHANGELOG, which is absolutely welcome 👌

I don’t believe anybody has started on this yet (correct me if I’m wrong @TheSavior), so please feel free to make a PR into this branch. It would probably be best for now to limit changes to moving around those that are in the unknown/wrong section and leave the internal ones to FB people to resolve.

As for the folding together of details about new features such as Flipper; I generally prefer that, but will defer to the people that have been doing these releases longer than I have.

jeremy-deutsch · 2020-03-18T19:53:03Z

@alloy Sounds good to me! I’ll take a look to see if anything might be better categorized, but hold off on marking anything else as internal or non-stable-RN. The big bucket of suggestion comments might not have been the perfect approach here 🙂

alloy · 2020-03-18T22:04:58Z

Ace, thanks 🙏

kelset · 2020-03-19T10:11:07Z

hey folks - I should have some time today so I'll tackle this in the next couple hours. @jeremy-deutsch I really want to thank you for all your feedback! And don't worry, leaving all those comments is ok - luckily now GH has some nice UX over hiding addressed comments.

I'll try to merge everything you proposed, then do another cleanup, then report back - so that you don't have to waste time re-addressing all the changes you have proposed as a PR 👍

#169

alloy · 2020-03-20T11:20:16Z

@jeremy-deutsch To follow up on my earlier comment, if you’d like to be more actively involved in work like this, please reach out to me at eloy.de.enige@gmail.com

* Address unknown changelog entries * Updates from feedback * Add andorid changes back

rickhanlonii · 2020-03-20T22:57:25Z

Ok all the unknowns have been categorized or removed 👍

* Groom 0.62 Changelog * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Apply suggestions from code review Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Add Flipper, feedback from reviews Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

kelset · 2020-03-24T17:40:35Z

CHANGELOG.md

+
+This feature release of React Native includes many changes for the platform: it has been a lot of work, so please refer to the [blog post](ADD) for overlook of the main changes - like Flipper support and the new LogBox.
+
+As always, we’ve done our best to test this release at length, especially with this being such a large release. However, note that due to challenges caused by COVID-19 to people everywhere, we [the maintainers] may not have the bandwidth we’d like to have for quick follow-up on bugs and/or a patch release. When you run into an issue, please do try to provide a fix or a detailed ticket, but be prepared to revert to the version you were previously on to unblock yourself.


@alloy just a super quick question, in this phrase

[the maintainers]

is this supposed to be a link to something or it was more like " we = the maintainers"?

The latter 👍

kelset · 2020-03-24T17:41:36Z

Thanks to everyone for their comments, it looks like we are (almost!) ready to merge this.

Only two things missing are the links to the blogpost (still not up) and to the dedicated issue (still not open).

Anything else that I may be forgetting?

jeremy-deutsch · 2020-03-24T17:45:30Z

@kelset I have some formatting/consistency nits, but nothing blocking (PR here)

kelset · 2020-03-24T18:16:24Z

thanks @jeremy-deutsch! Merged 👍

* Update 0.62 description * Apply suggestions from code review Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

CHANGELOG.md

Co-Authored-By: Core <aukwat@gmail.com>

CHANGELOG.md

thymikee · 2020-03-26T17:18:36Z

CHANGELOG.md

+- Limit size of video uploaded from camera roll in android (< 100 MB) ([d21f695edf](https://github.com/facebook/react-native/commit/d21f695edf367166a03af4c6e9376cd498b38665))
+- Remove "Reload on JS change" from RN Android ([478df155e7](https://github.com/facebook/react-native/commit/478df155e70a4ce30219adcac6f0801c4e4d10ec) by [@cpojer](https://github.com/cpojer))
+
+#### iOS specific


this is empty, so remove?

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>

kelset added the changelog entry label Mar 3, 2020

kelset requested review from alloy, elicwhite and turnrye March 3, 2020 17:24

elicwhite reviewed Mar 3, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

elicwhite reviewed Mar 3, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

alloy mentioned this pull request Mar 3, 2020

[changelog-generator] Group unknown entries by author #168

Closed

youngjuning reviewed Mar 3, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

elicwhite reviewed Mar 3, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

alloy force-pushed the chore/062-changelog-new branch from b3c2257 to 3e7e9b6 Compare March 6, 2020 23:42

jeremy-deutsch reviewed Mar 7, 2020

View reviewed changes

kelset mentioned this pull request Mar 17, 2020

0.62.x RC Discussion #157

Closed

6 tasks

kelset force-pushed the chore/062-changelog-new branch from 6ba652b to d362d78 Compare March 19, 2020 12:27

kelset and others added 2 commits March 19, 2020 13:36

changelog for 0.62 up to rc3

0e0ffed

[CHANGELOG] Update after fixing commit resolving

3539361

#169

Address unknown changelog entries (#175)

c376c78

* Address unknown changelog entries * Updates from feedback * Add andorid changes back

kelset marked this pull request as ready for review March 24, 2020 17:35

kelset commented Mar 24, 2020

View reviewed changes

changelog: removed duplicates and fixed inconsistent formatting (#177)

adcc0dd

Update 0.62 description (#178)

ced159b

* Update 0.62 description * Apply suggestions from code review Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

alloy reviewed Mar 25, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

HelloCore reviewed Mar 26, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

alloy and others added 2 commits March 26, 2020 15:41

Fix typo

2b41f91

Co-Authored-By: Core <aukwat@gmail.com>

Remove a known issue

e2138bd

thymikee reviewed Mar 26, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

thymikee reviewed Mar 26, 2020

View reviewed changes

Update CHANGELOG.md

9c42bda

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>

kelset merged commit 924c19d into master Mar 26, 2020

kelset deleted the chore/062-changelog-new branch March 26, 2020 17:28

alloy mentioned this pull request Mar 30, 2020

Changed proguard rule for Hermes is not specified in the upgrade helper for 0.62. react-native-community/upgrade-support#19

Closed

snyk-bot mentioned this pull request May 4, 2020

[Snyk] Upgrade react-native from 0.55.4 to 0.62.2 gicontz/UMirror#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New 0.62.0 changelog #166

New 0.62.0 changelog #166

kelset commented Mar 3, 2020 •

edited

Loading

jeremy-deutsch commented Mar 3, 2020

elicwhite commented Mar 3, 2020

jeremy-deutsch commented Mar 3, 2020

alloy commented Mar 3, 2020 •

edited

Loading

alloy commented Mar 3, 2020

kelset commented Mar 4, 2020

alloy commented Mar 6, 2020

elicwhite commented Mar 7, 2020

alloy commented Mar 7, 2020

jeremy-deutsch left a comment

rickhanlonii commented Mar 18, 2020

elicwhite commented Mar 18, 2020

alloy commented Mar 18, 2020

jeremy-deutsch commented Mar 18, 2020

alloy commented Mar 18, 2020

kelset commented Mar 19, 2020

alloy commented Mar 20, 2020

rickhanlonii commented Mar 20, 2020

kelset Mar 24, 2020

alloy Mar 24, 2020

kelset commented Mar 24, 2020

jeremy-deutsch commented Mar 24, 2020 •

edited

Loading

kelset commented Mar 24, 2020

thymikee Mar 26, 2020


		This feature release of React Native includes many changes for the platform: it has been a lot of work, so please refer to the [blog post](ADD) for overlook of the main changes - like Flipper support and the new LogBox.

		As always, we’ve done our best to test this release at length, especially with this being such a large release. However, note that due to challenges caused by COVID-19 to people everywhere, we [the maintainers] may not have the bandwidth we’d like to have for quick follow-up on bugs and/or a patch release. When you run into an issue, please do try to provide a fix or a detailed ticket, but be prepared to revert to the version you were previously on to unblock yourself.

New 0.62.0 changelog #166

New 0.62.0 changelog #166

Conversation

kelset commented Mar 3, 2020 • edited Loading

jeremy-deutsch commented Mar 3, 2020

elicwhite commented Mar 3, 2020

jeremy-deutsch commented Mar 3, 2020

alloy commented Mar 3, 2020 • edited Loading

alloy commented Mar 3, 2020

kelset commented Mar 4, 2020

alloy commented Mar 6, 2020

elicwhite commented Mar 7, 2020

alloy commented Mar 7, 2020

jeremy-deutsch left a comment

Choose a reason for hiding this comment

rickhanlonii commented Mar 18, 2020

elicwhite commented Mar 18, 2020

alloy commented Mar 18, 2020

jeremy-deutsch commented Mar 18, 2020

alloy commented Mar 18, 2020

kelset commented Mar 19, 2020

alloy commented Mar 20, 2020

rickhanlonii commented Mar 20, 2020

kelset Mar 24, 2020

Choose a reason for hiding this comment

alloy Mar 24, 2020

Choose a reason for hiding this comment

kelset commented Mar 24, 2020

jeremy-deutsch commented Mar 24, 2020 • edited Loading

kelset commented Mar 24, 2020

thymikee Mar 26, 2020

Choose a reason for hiding this comment

kelset commented Mar 3, 2020 •

edited

Loading

alloy commented Mar 3, 2020 •

edited

Loading

jeremy-deutsch commented Mar 24, 2020 •

edited

Loading