Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.62.x RC Discussion #157

Closed
6 tasks done
kelset opened this issue Jan 21, 2020 · 152 comments
Closed
6 tasks done

0.62.x RC Discussion #157

kelset opened this issue Jan 21, 2020 · 152 comments
Labels
pre-release rc Release candidate

Comments

@kelset
Copy link
Member

kelset commented Jan 21, 2020 •
edited by alloy
Loading

EDIT by @alloy:

The current version is v0.62.0-rc.5 and appears to be the golden one ✨

TODOs:
@kelset kelset added rc Release candidate pre-release labels Jan 21, 2020
@kelset kelset mentioned this issue Jan 21, 2020
Closed
@kelset kelset pinned this issue Jan 21, 2020
@SaeedZhiany

This comment has been minimized.

Sign in to view
@khat33b

This comment has been minimized.

Sign in to view
@kelset

This comment has been minimized.

Sign in to view
@sofiageo

This comment has been minimized.

Sign in to view
@kelset

This comment has been minimized.

Sign in to view
@elicwhite elicwhite mentioned this issue Jan 26, 2020
Closed
@jfrolich

This comment has been minimized.

Sign in to view
@kelset
Copy link
Member Author

kelset commented Jan 28, 2020

@jfrolich I would recommend that you open an issue in the react-native-nav rep with a repro, and post the link here. So people can have the conversation over there while keeping a reference here.

Just a quick update, the roadmap for 0.62.0 is mostly bound to Flipper support - and since I forgot to mention it in the previous post I'll add it here now: facebook/react-native#27565

So it seems that there is still some work to do before it's going to be ready. Any help I'm sure it would be super appreciated.

@johnckendall

This comment has been minimized.

Sign in to view
@alexisbronchart

This comment has been minimized.

Sign in to view
@mjmasn

This comment has been minimized.

Sign in to view
@kelset

This comment has been minimized.

Sign in to view
@Gustash

This comment has been minimized.

Sign in to view
@trevyn

This comment has been minimized.

Sign in to view
@meosieudang

This comment has been minimized.

Sign in to view
@jamesisaac jamesisaac mentioned this issue Feb 4, 2020
Closed
@panagosg7

This comment has been minimized.

Sign in to view
@elicwhite

This comment has been minimized.

Sign in to view
@mjmasn

This comment has been minimized.

Sign in to view
@elicwhite

This comment has been minimized.

Sign in to view
@jacobp100

This comment has been minimized.

Sign in to view
@Naturalclar Naturalclar mentioned this issue Feb 6, 2020
Closed
@Naturalclar

This comment has been minimized.

Sign in to view
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Feb 7, 2020
@Naturalclar @facebook-github-bot
chore: add eslint back to template (#27983)
8216567 
Summary:
This PR is part of react-native-community/releases#157 (comment)
Adding eslint back to the template package.json

## Changelog

[Internal] [Fixed] - Add eslint back in template
Pull Request resolved: #27983

Test Plan:
(edited)
- npx react-native init RN062 --version 0.62.0-rc.1
- yarn add -d eslint
- add npm script for lint
- yarn lint

Differential Revision: D19784567

Pulled By: TheSavior

fbshipit-source-id: 9ce24c0b674c2b1ea9fee3ed5614e8922f992f72
@elicwhite

This comment has been minimized.

Sign in to view
@kelset

This comment has been minimized.

Sign in to view
@Sixzero
Copy link

Sixzero commented Mar 11, 2020 •
edited
Loading

We tried 0.62.0-rc.5 both on Android and iOS and our experience was:

As for iOS react-native-firebase and flipper causes duplicate symbol conflicts, which I think will be addressed soon, since I think a lots of project uses firebase. Already there was an issue about this problem on stackoverflow from 2019 july, which talks about the problem.

  • We temporarily disabled flipper and now everything works fine.

As for Android the new 6.0.1-all gradle causes an issue in the react-native-ble-plx library, since it uses "groovy" in their Android codes.

  • As a temporary solution we didn't upgrade the gradle version.

Apart from these 2 bugs(as for us) the upgrade went smooth and fast. Great work, keep it up!

P.s still haven't created issues about the two issues in their specific repos.

@elicwhite
Copy link
Contributor

It would be very helpful to have issues for those that we can keep an eye on.

@alloy
Copy link
Member

alloy commented Mar 11, 2020 •
edited
Loading

@alloy can you share an update on the current status? Are there currently issues we are waiting to get resolved? Are we just giving RC5 a couple days to soak? What else is blocking this from going stable that you know of (the changelog is one example).

@TheSavior Initially I was keeping an eye on those Android crashes, but by now it seems like those are addressable outside of any release changes. So now it was only a matter of letting it soak a bit more.

Work we need done to finalise the release are:

  • Changelog cleanup
  • Blog post
  • On my end, create some essential new TS typings (which I will do this week)

So perhaps we can aim for a stable release (not RC) by Monday?

@grabbou @kelset Are you available then to assist me?

@SaeedZhiany

This comment has been minimized.

Sign in to view
@alloy

This comment has been minimized.

Sign in to view
@bmbmjmdm
Copy link

@alloy not sure what you mean about the Android crashes being addressable. I still can't get a successful release launch (though as I said in my thread I still need to try on rc-5)

@alloy
Copy link
Member

alloy commented Mar 11, 2020 •
edited
Loading

@bmbmjmdm From what limited judging I can do at this time, your issue seems like it may be an issue we can solve in user-land (see my comment on your issue facebook/react-native#28163 (comment)) and is currently not being reported by others. If it turns out to be an issue that needs fixing in RN after all, then we can release a fix in a subsequent patch release. For now, my personal opinion is that we should get this long overdue release out and then iterate faster in the future.

@elicwhite
Copy link
Contributor

Do these flipper commits need to get picked?
facebook/react-native@db12255
facebook/react-native@85a4b0f

@mweststrate
Copy link

@TheSavior preferably yes, otherwise people will have to bump manually if they want to use all features of the integration.

@passy
Copy link

passy commented Mar 11, 2020

The Android changes are optional-ish. The iOS fix includes the lowering of the SDK min version back to 9. Ultimately, it's probably better to keep the two in sync, though.

@elicwhite
Copy link
Contributor

elicwhite commented Mar 12, 2020 •
edited
Loading

We just got an internal report about long press inconsistently firing on the touchables due to a refactor of the internal state machine that landed in 0.62 in a stack of commits starting with facebook/react-native@ebf7d75

@yungsters is able to repro and will investigate a fix tomorrow. I wanted to flag here as a known problem with 0.62 right now.

@elicwhite
Copy link
Contributor

Long press fix landed here: facebook/react-native@5ca1d8f.

We haven’t soaked this fix internally yet, we’ll let you know if we hear any additional issues from our internal users from this.

FWIW, I think this issue is a pretty minor edge case as we had been running with this bug in production for at least 6 months and hadn’t heard it surfaced until now.

@sebqq
Copy link

sebqq commented Mar 17, 2020

What is the status please?

@kelset
Copy link
Member Author

kelset commented Mar 17, 2020

Hey folks - given how the situation of CoVid-19 is spreading through the world, we are discussing if it's a sensible thing to proceed with 0.62.0 this week.

It's likely that we will still proceed but no ultimate decision out atm. We will keep you updated - we are just as eager as you to finally have it out in the wild, but we need to be considerate towards everyone and this new balance that is shaping up all over the world 🤗💗

@dentuzhik
Copy link

@kelset hopefully you guys are going to work this out 🙌
IMO there's certainly little need to rush out releases like this given what's happening around

@robertying
Copy link

Is there a plan to solve the increased apk size caused by gradle version bump?
Or should we just stick to the workaround as #157 (comment) suggested for the time being?

Thanks!

@alloy
Copy link
Member

alloy commented Mar 17, 2020

@robertying Afaik there’s no progress on that atm, so expect to use the workaround for the time being. Having said that, it doesn’t seem like there’s a ticket tracking this issue, at least I haven’t seen it mentioned, so perhaps you could create one that combines @willholen’s and @ArrayZoneYour’s comments.

@robertying robertying mentioned this issue Mar 17, 2020
Closed
@robertying
Copy link

I'll link the issue here.

Android APK size increases after Gradle version bump: facebook/react-native#28330

@kelset
Copy link
Member Author

kelset commented Mar 17, 2020

(just FYI @alloy updated the top post of this issue with the checklist of things we are working on for 0.62.0)

@grabbou
Copy link
Member

grabbou commented Mar 18, 2020

As discussed with @alloy, jumping on the commits to do the cherry-picks. Will report with the update.

@nonewcode
Copy link

Is a 0.62 release still being planned for the next couple of days?

@kelset
Copy link
Member Author

kelset commented Mar 23, 2020

@codecog if you check the original post at the top, you'll see that the checklist is not yet complete. At the moment we are focusing on completing those tasks, once they will be done we will be able to proceed.

As mentioned, just like everyone else all around the world, the CoVid-19 situation is also affecting the amount of time the developers involved in this phase are able to dedicate to the process. We will communicate once the release is going to be out... when it's going to be ready. No deadlines nor fixed dates atm - please be patient 💕

@nonewcode
Copy link

@kelset anything i can help with to get us there faster?

@SergioEstevao
Copy link

@kelset and @alloy do you think we can have this PR: facebook/react-native#28332 cherry-picked for the release?

@kelset
Copy link
Member Author

kelset commented Mar 23, 2020 •
edited
Loading

@codecog thanks for asking! I fear that atm there isn't much that can be done 😓 The only one of those to do points that is kind of actionable is the changelog one: we have a draft PR #166 currently being worked on, but Ricky is already on the case on his side-PR to improve on it #176 and he has already a few feedbacks on it to improve it. I'm sure an extra pair of eyes would be super helpful to spot things we may have missed, since it's just a massive changelog. But yeah atm aside from that I'm not sure what could be done.

If you are an Android user, maybe you could help us out with understanding better what's going on in facebook/react-native#28163. I feel that we could use a comment to summarize the issue and provide a clearly defined workaround.

@SergioEstevao I don't think we will add other commits aside from the ones defined in the top post, sorry. Maybe for 0.62.1.

@kelset
Copy link
Member Author

kelset commented Mar 26, 2020

Hey everyone, we've released 0.62.0 (read more) 🚀

Please refer to the dedicated issue from now on #179

@kelset kelset closed this as completed Mar 26, 2020
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Mar 26, 2020
@kelset kelset unpinned this issue Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pre-release rc Release candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests