This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
[changelog-generator] Fix original commit resolving #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
commented
Mar 4, 2020
| return git( | ||
| gitDir, | ||
| "log", | ||
| "master", | ||
| "--pretty=format:%H", | ||
| `--grep=${drev}` | ||
| `--grep=${match[0]}` |
There was a problem hiding this comment.
This was too ambiguous, as some commit messages refer to these differential revisions too.
alloy
added a commit
that referenced
this pull request
Mar 4, 2020
Merged
elicwhite
approved these changes
Mar 4, 2020
| return git( | ||
| gitDir, | ||
| "log", | ||
| "master", | ||
| "--pretty=format:%H", | ||
| `--grep=${drev}` | ||
| `--grep=${match[0]}` | ||
| ).then(sha => { |
There was a problem hiding this comment.
Do you want to add an assert that there is only one match?
| @@ -5,7 +5,8 @@ | |||
| "scripts": { | |||
| "format": "prettier *.md scripts{,/**}/*.js --write", | |||
| "format:check": "prettier *.md scripts{,/**}/*.js --list-different", | |||
| "generate": "ts-node --transpile-only ./scripts/changelog-generator.ts", | |||
There was a problem hiding this comment.
What does this change do?
There was a problem hiding this comment.
This makes it possible to have scripts that specify node options, such as the generate:debug command that allows attaching a debugger. When $_NODE_OPTS is undefined the command is technically identical to the previous version.
|
Alright, shipping it |
alloy
added a commit
that referenced
this pull request
Mar 6, 2020
kelset
pushed a commit
that referenced
this pull request
Mar 19, 2020
kelset
pushed a commit
that referenced
this pull request
Mar 19, 2020
kelset
added a commit
that referenced
this pull request
Mar 26, 2020
* changelog for 0.62 up to rc3 * [CHANGELOG] Update after fixing commit resolving #169 * [CHANGELOG] Update for v0.62.0-rc.4 * [CHANGELOG] Sort unknowns by author * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * small tweaks to remove a couple warnings * a few more typos fixes * feedback * remove empty section * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * last feedback from Jeremy * couple other tweaks * better fix for it * adding a draft for the intro * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * changelog: move around some misplaced commits (#174) * add more details about CLI upgrade * Address unknown changelog entries (#175) * Address unknown changelog entries * Updates from feedback * Add andorid changes back * Groom 0.62 Changelog (#176) * Groom 0.62 Changelog * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Apply suggestions from code review Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Add Flipper, feedback from reviews Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * changelog: removed duplicates and fixed inconsistent formatting (#177) * Update 0.62 description (#178) * Update 0.62 description * Apply suggestions from code review Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Fix typo Co-Authored-By: Core <aukwat@gmail.com> * Remove a known issue * Update CHANGELOG.md Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> Co-authored-by: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> Co-authored-by: Jeremy Deutsch <jeremy.deutsch@smarkets.com> Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Core <aukwat@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/react-native-community/releases/pull/166/files#r387227509 & https://github.com/react-native-community/releases/pull/166/files#r387227231