Fixing Python2 compatibility issues. Adding inline docs #3656
Conversation
python/ray/tempfile_services.py
Outdated
| # on a directory may not own it. The chmod is attempted whether the | ||
| # directory is new or not to avoid race conditions. | ||
| # ray-project/ray/#3591 | ||
| if e.errno == errno.EACCES: |
There was a problem hiding this comment.
When I try this locally, the error I get is errno.EPERM. Maybe add that in as well?
|
Test FAILed. |
|
Is it worth adding a test for this?
…On Sat, Dec 29, 2018 at 7:40 AM UCB AMPLab ***@***.***> wrote:
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/10484/
Test FAILed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3656 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEUc5aXmCSngo8DlduijWpelXC1Nl5dpks5u9qvxgaJpZM4ZkMzz>
.
|
|
@robertnishihara Sure, I will add it. @richardliaw Testing would require two users and a script similar to that in #3590. Does travis have multiple users we can |
|
Test FAILed. |
|
In this case, I don't think the test is necessary. But @devin-petersohn I think it should be possible to do something like |
What do these changes do?
Fixes compatibility issues introduced in #3591
Related issue number
Resolves #3652