Allowing multiple users to access the /tmp/ray file at the same time #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous sequence that caused this issue: * User A starts ray with `ray.init` when /tmp/ray does not exist * User B starts ray with `ray.init` and /tmp/ray now exists User B will get a permissions error Checking the permissions, /tmp/ray is 700 I have identified a race condition in `try_to_create_directory` * Multiple processes try to create /tmp/ray at the same time * chmod is either silently erroring or working properly within the race condition Resolution: Move chmod outside of the check for whether the directory exists or not.
pcmoritz
approved these changes
Dec 20, 2018
|
Test FAILed. |
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous sequence that caused this issue:
ray.initwhen /tmp/ray does not existray.initand /tmp/ray now existsUser B will get a permissions error
Checking the permissions, /tmp/ray is 700
I have identified a race condition in
try_to_create_directoryResolution: Move chmod outside of the check for whether the directory exists or not.
What do these changes do?
Related issue number