Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Python2 compatibility issues. Adding inline docs #3656

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Fixing Python2 compatibility issues. Adding inline docs #3656

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eefd18
Fixing Python2 compatibility issues. Adding inline docs
devin-petersohn Dec 28, 2018
4eeea3e
Addressing comment
devin-petersohn Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions python/ray/tempfile_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,16 @@ def try_to_create_directory(directory_path):
# important when multiple people are using the same machine.
try:
os.chmod(directory_path, 0o0777)
except PermissionError:
pass
except OSError as e:
# Silently suppress the PermissionError that is thrown by the chmod.
# This is done because the user attempting to change the permissions
# on a directory may not own it. The chmod is attempted whether the
# directory is new or not to avoid race conditions.
# ray-project/ray/#3591
if e.errno == errno.EACCES:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try this locally, the error I get is errno.EPERM. Maybe add that in as well?

pass
else:
raise


def get_temp_root():
Expand Down