Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Remove dashboard's dependency on Serve #23389

Merged
merged 13 commits into from
Mar 22, 2022
Merged

[serve] Remove dashboard's dependency on Serve #23389

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e4f6092
Make serve a delayed import
shrekris-anyscale Mar 21, 2022
5281fd1
Add dependency test
shrekris-anyscale Mar 21, 2022
2cc000d
Turn off test if not using minimal installation
shrekris-anyscale Mar 21, 2022
f93a281
Uncomment code
shrekris-anyscale Mar 21, 2022
3503a3b
Add colon
shrekris-anyscale Mar 21, 2022
2846b76
Delay serve imports
shrekris-anyscale Mar 21, 2022
608b545
Add new job using default dependencies
shrekris-anyscale Mar 21, 2022
46f51ae
Make shell script to install default dependencies
shrekris-anyscale Mar 21, 2022
0442385
Use default installation on test_dashboard.py
shrekris-anyscale Mar 21, 2022
7520cb7
Treat environment variables as strings
shrekris-anyscale Mar 21, 2022
02a3772
Remove unnecessary RAY_DEFAULT skip statements
shrekris-anyscale Mar 21, 2022
afa2111
Check that standard dashboard features work without serve dependency
shrekris-anyscale Mar 22, 2022
b13c61c
Fix URL
shrekris-anyscale Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix URL
  • Loading branch information
@shrekris-anyscale
shrekris-anyscale committed Mar 22, 2022
commit b13c61cfd91599c7bda088dd57cb78e220542b28
2 changes: 1 addition & 1 deletion dashboard/tests/test_dashboard.py
View file
Original file line number Diff line number Diff line change
@@ -718,7 +718,7 @@ def test_dashboard_does_not_depend_on_serve():
ctx = ray.init(include_dashboard=True)

# Ensure standard dashboard features, like snapshot, still work
response = requests.get(f"http://{ctx.dashboard_url}/api/snapshot/")
response = requests.get(f"http://{ctx.dashboard_url}/api/snapshot")
assert response.status_code == 200
assert response.json()["result"] is True
assert "snapshot" in response.json()["data"]