-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Remove dashboard's dependency on Serve #23389
Merged
+63
−10
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e4f6092
Make serve a delayed import
shrekris-anyscale 5281fd1
Add dependency test
shrekris-anyscale 2cc000d
Turn off test if not using minimal installation
shrekris-anyscale f93a281
Uncomment code
shrekris-anyscale 3503a3b
Add colon
shrekris-anyscale 2846b76
Delay serve imports
shrekris-anyscale 608b545
Add new job using default dependencies
shrekris-anyscale 46f51ae
Make shell script to install default dependencies
shrekris-anyscale 0442385
Use default installation on test_dashboard.py
shrekris-anyscale 7520cb7
Treat environment variables as strings
shrekris-anyscale 02a3772
Remove unnecessary RAY_DEFAULT skip statements
shrekris-anyscale afa2111
Check that standard dashboard features work without serve dependency
shrekris-anyscale b13c61c
Fix URL
shrekris-anyscale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check that standard dashboard features work without serve dependency
Access has been restricted
You have triggered a rate limit.
Please wait a few minutes before you try again;
in some cases this may take up to an hour.
commit afa2111c8564c03b8aedf96bada76f43e43ff841
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ray dashboard doesn't work with minimal install. ray dashboard only works when ray[default] is installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I added a script to perform the test with a default installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check regular dashboard process works (e.g. /api/snapshot) and serve doesn't?