-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Remove dashboard's dependency on Serve #23389
Conversation
from ray import serve # noqa F401 | ||
|
||
ray.init(include_dashboard=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ray dashboard doesn't work with minimal install. ray dashboard only works when ray[default] is installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I added a script to perform the test with a default installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check regular dashboard process works (e.g. /api/snapshot) and serve doesn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you drop all the
@pytest.mark.skipif(
os.environ.get("RAY_DEFAULT") == "1",
reason="This test may not work with default installation.",
)
ray dashboard (all the tests) should work with ray default install
from ray import serve # noqa F401 | ||
|
||
ray.init(include_dashboard=True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check regular dashboard process works (e.g. /api/snapshot) and serve doesn't?
Why are these changes needed?
The Ray dashboard imports Serve even when it doesn't need to start the Serve controller. This change makes this a delayed import and removes the hard dependency.
It also adds a new job to the CI that uses Ray's default dependencies (i.e. the ones installed by "pip install ray[default]").
Related issue number
Closes #23309.
Checks
scripts/format.sh
to lint the changes in this PR.test_dashboard.py
.