Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to github from documentation. #1425

Merged
merged 2 commits into from
Jan 19, 2018
Merged

Add link to github from documentation. #1425

merged 2 commits into from
Jan 19, 2018

Conversation

robertnishihara
Copy link
Collaborator

Fixes #1384.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3230/
Test PASSed.

@richardliaw
Copy link
Contributor

Looks good; we can also consider a "Fork me on Github" banner.

@robertnishihara
Copy link
Collaborator Author

The "fork me on github" banner could be a good idea, although most people who click on that usually don't want to "fork" the repository, they just want to go to the github page, right?

@richardliaw
Copy link
Contributor

Not sure... Another option for the banner is to customize it to say "View Ray on Github".

I'd imagine there are people who are interested in contributing and also others who are interested in the implementation. The banner is probably good for the former while source links (like in Numpy and Pandas pandas-dev/pandas#14178) are good for the latter.

@robertnishihara
Copy link
Collaborator Author

Ok, I added the banner. Should I get rid of the other link then? Or is it fine as is?

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3235/
Test PASSed.

@richardliaw
Copy link
Contributor

richardliaw commented Jan 15, 2018

I think both are fine!

@richardliaw richardliaw merged commit ed603fc into ray-project:master Jan 19, 2018
royf added a commit to royf/ray that referenced this pull request Jan 20, 2018
* master:
  Add some development tips to documentation. (ray-project#1426)
  Add link to github from documentation. (ray-project#1425)
  [rllib] Update docs with api and components overview figures (ray-project#1443)
  Multiagent model using concatenated observations (ray-project#1416)
  Load evaluation configuration from checkpoint (ray-project#1392)
  [autoscaling] increase connect timeout, boto retries, and check subnet conf (ray-project#1422)
  Update wheel in autoscaler example. (ray-project#1408)
  [autoscaler] Fix ValueError: Missing required config keyavailability_zoneof type str
  [tune][minor] Fixes (ray-project#1383)
  [rllib] Expose PPO evaluator resource requirements (ray-project#1391)
  fix autoscaler test (ray-project#1411)
  [rllib] Fix incorrect documentation on how to use custom models ray-project#1405
  Added option for availability zone (ray-project#1393)
  Adding all DataFrame methods with NotImplementedErrors (ray-project#1403)
  Remove pyarrow version check. (ray-project#1394)

# Conflicts:
#	python/ray/rllib/eval.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants