-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to github from documentation. #1425
Conversation
Merged build finished. Test PASSed. |
Test PASSed. |
Looks good; we can also consider a "Fork me on Github" banner. |
The "fork me on github" banner could be a good idea, although most people who click on that usually don't want to "fork" the repository, they just want to go to the github page, right? |
Not sure... Another option for the banner is to customize it to say "View Ray on Github". I'd imagine there are people who are interested in contributing and also others who are interested in the implementation. The banner is probably good for the former while source links (like in Numpy and Pandas pandas-dev/pandas#14178) are good for the latter. |
Ok, I added the banner. Should I get rid of the other link then? Or is it fine as is? |
Merged build finished. Test PASSed. |
Test PASSed. |
I think both are fine! |
* master: Add some development tips to documentation. (ray-project#1426) Add link to github from documentation. (ray-project#1425) [rllib] Update docs with api and components overview figures (ray-project#1443) Multiagent model using concatenated observations (ray-project#1416) Load evaluation configuration from checkpoint (ray-project#1392) [autoscaling] increase connect timeout, boto retries, and check subnet conf (ray-project#1422) Update wheel in autoscaler example. (ray-project#1408) [autoscaler] Fix ValueError: Missing required config keyavailability_zoneof type str [tune][minor] Fixes (ray-project#1383) [rllib] Expose PPO evaluator resource requirements (ray-project#1391) fix autoscaler test (ray-project#1411) [rllib] Fix incorrect documentation on how to use custom models ray-project#1405 Added option for availability zone (ray-project#1393) Adding all DataFrame methods with NotImplementedErrors (ray-project#1403) Remove pyarrow version check. (ray-project#1394) # Conflicts: # python/ray/rllib/eval.py
Fixes #1384.