[autoscaler] Fix autoscaler test #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
ericl
approved these changes
Jan 10, 2018
|
I don't think this is the right fix. The availability zone should not be required. |
|
Yeah, I think @pschafhalter has a fix that makes the availability zone optional, do you want to create a PR? |
royf
added a commit
to royf/ray
that referenced
this pull request
Jan 20, 2018
* master: Add some development tips to documentation. (ray-project#1426) Add link to github from documentation. (ray-project#1425) [rllib] Update docs with api and components overview figures (ray-project#1443) Multiagent model using concatenated observations (ray-project#1416) Load evaluation configuration from checkpoint (ray-project#1392) [autoscaling] increase connect timeout, boto retries, and check subnet conf (ray-project#1422) Update wheel in autoscaler example. (ray-project#1408) [autoscaler] Fix ValueError: Missing required config keyavailability_zoneof type str [tune][minor] Fixes (ray-project#1383) [rllib] Expose PPO evaluator resource requirements (ray-project#1391) fix autoscaler test (ray-project#1411) [rllib] Fix incorrect documentation on how to use custom models ray-project#1405 Added option for availability zone (ray-project#1393) Adding all DataFrame methods with NotImplementedErrors (ray-project#1403) Remove pyarrow version check. (ray-project#1394) # Conflicts: # python/ray/rllib/eval.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test failure that was introduces with the
availability_zone.