Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune][minor] Fixes #1383

Merged
merged 4 commits into from
Jan 12, 2018
Merged

[tune][minor] Fixes #1383

merged 4 commits into from
Jan 12, 2018

Conversation

richardliaw
Copy link
Contributor

What do these changes do?

  • Fixes a "Directory not found" error when running on multiple nodes
  • Adds done note in the last result logged, which helps users understand whether a trial actually completed or the cluster crashed without completing the trial correctly.

cc: @ericl

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3058/
Test FAILed.

ericl
ericl reviewed Jan 1, 2018
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the done=True?

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3191/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3194/
Test PASSed.

@richardliaw richardliaw merged commit d459238 into ray-project:master Jan 12, 2018
royf added a commit to royf/ray that referenced this pull request Jan 20, 2018
@royf
Merge branch 'master' into imitationlearning
1aafd5b 
* master:
  Add some development tips to documentation. (ray-project#1426)
  Add link to github from documentation. (ray-project#1425)
  [rllib] Update docs with api and components overview figures (ray-project#1443)
  Multiagent model using concatenated observations (ray-project#1416)
  Load evaluation configuration from checkpoint (ray-project#1392)
  [autoscaling] increase connect timeout, boto retries, and check subnet conf (ray-project#1422)
  Update wheel in autoscaler example. (ray-project#1408)
  [autoscaler] Fix ValueError: Missing required config keyavailability_zoneof type str
  [tune][minor] Fixes (ray-project#1383)
  [rllib] Expose PPO evaluator resource requirements (ray-project#1391)
  fix autoscaler test (ray-project#1411)
  [rllib] Fix incorrect documentation on how to use custom models ray-project#1405
  Added option for availability zone (ray-project#1393)
  Adding all DataFrame methods with NotImplementedErrors (ray-project#1403)
  Remove pyarrow version check. (ray-project#1394)

# Conflicts:
#	python/ray/rllib/eval.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardliaw @AmplabJenkins @ericl