-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CommonGeometryColumnFixture
for Common Geometry Column Reuse
#1104
Create CommonGeometryColumnFixture
for Common Geometry Column Reuse
#1104
Conversation
linestring_polygon_distance_test.cpp
to distance/
linestring_polygon_distance_test.cpp
to distance/
So some of this was done by #1097 but it looks like this also refactors some test fixture code. So perhaps the title of this PR should change?
|
…into improvement/move_linestring_polygon_distance
linestring_polygon_distance_test.cpp
to distance/
CommonGeometryColumnFixture
for Common Geometry Column Reuse
Let's hold on reviewing this PR, thinking on a better design for the geometry fixtures. |
Supersedes by #1124 |
This PR makes all ST_Distance API conforms to a homogenous API format and documentation. This also greatly simplifies the implementation of each of the column APIs. Closes #1123 This PR also introduces several `GeometryColumnFixtures` that manages the life time of a few commonly used geometry columns and use them across the tests of these APIs. Supersedes #1104 This PR also fixes several bugs in the computation kernels when the input is empty. Authors: - Michael Wang (https://github.com/isVoid) - Mark Harris (https://github.com/harrism) Approvers: - Mark Harris (https://github.com/harrism) URL: #1124
Description
This PR adds a
CommonGeometryColumnFixture
manages the life cycle of some commonly used geometry columns that can be shared across different test suites. Currently, only empty geometry columns are added.Checklist