Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize src, tests, and benchmarks #1115

Conversation

harrism
Copy link
Member

@harrism harrism commented May 3, 2023

Description

Fixes #663.
Also fixes #1105

Organizes all source, test, and benchmark files into directories matching the names of the associated headers that define the APIs they implement/test/benchmark.

Also fixes up documentation so it is consistent with this.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested review from a team as code owners May 3, 2023 01:48
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels May 3, 2023
@harrism harrism added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 3, 2023
@harrism harrism self-assigned this May 3, 2023
@trxcllnt
Copy link
Contributor

trxcllnt commented May 3, 2023

cpp/tests/distance/polygon_distance_test.cpp:21:10: fatal error: cuspatial/distance/polygon_distance.hpp: No such file or directory
   21 | #include <cuspatial/distance/polygon_distance.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

@harrism
Copy link
Member Author

harrism commented May 3, 2023

/merge

@isVoid
Copy link
Contributor

isVoid commented May 4, 2023

Looks like cython file for polygon_distance require updating.

$SRC_DIR/python/cuspatial/_skbuild/linux-x86_64-3.9/cmake-build/cuspatial/_lib/distance.cxx:792:10: fatal error: cuspatial/distance/polygon_distance.hpp: No such file or directory
  792 | #include "cuspatial/distance/polygon_distance.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

@harrism harrism requested a review from a team as a code owner May 4, 2023 02:21
@github-actions github-actions bot added the Python Related to Python code label May 4, 2023
@rapids-bot rapids-bot bot merged commit e1de9f5 into rapidsai:branch-23.06 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

[BUG]: linestring_polygon_distance_test.cpp is out of place Improve C++ source and header organization
4 participants