Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ST_Distance Column API and Cython #1124

Merged
merged 27 commits into from
May 16, 2023
Merged

Refactor ST_Distance Column API and Cython #1124

merged 27 commits into from
May 16, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented May 4, 2023 •
edited
Loading

Description

This PR makes all ST_Distance API conforms to a homogenous API format and documentation. This also greatly simplifies the implementation of each of the column APIs. Closes #1123

This PR also introduces several GeometryColumnFixtures that manages the life time of a few commonly used geometry columns and use them across the tests of these APIs. Supersedes #1104

This PR also fixes several bugs in the computation kernels when the input is empty.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

isVoid and others added 23 commits April 27, 2023 15:38
@isVoid
initial move
7d22d0f
@isVoid
style
ccace6c
@harrism
Reorganize src, tests, and benchmarks
1daff2d
@harrism
docs
b2b30a6
@harrism
Combine missed polygon_distance.hpp
10bf00c
@harrism
pragma once and copyrights
ea28304
@harrism
Fix distance include.
23fe07e
@isVoid
Merge branch 'branch-23.06' of https://github.com/rapidsai/cuspatial …
2675106 
…into improvement/move_linestring_polygon_distance
@isVoid
Merge remote-tracking branch 'harrism/feature/reorganize-src-tests-be…
aaa79c6 
…nchmarks' into improvement/standardizing_st_distance_headers
@isVoid
Merge branch 'improvement/move_linestring_polygon_distance' into impr…
5ef4a61 
…ovement/standardizing_st_distance_headers
@isVoid
Updates geometry fixture and use it with linestring_polygon distance …
2a6fa4e 
…column API test
@isVoid
refactor pairwise_point_distance
2916ace
@isVoid
update point_distance cpp test
c259811
@isVoid
refactors point linestring distance
1640e45
@isVoid
refactors linestring_distance
757f1a3
@isVoid
homogenize documentation
0e6d473
@isVoid
refactor cython
4ea73c3
@isVoid
remove unused dependencies
72eee7b
@isVoid
Merge branch 'branch-23.06' of https://github.com/rapidsai/cuspatial …
8c2e14f 
…into improvement/standardizing_st_distance_headers
@isVoid
python API refactor
d6861ea
@isVoid
assertion checks
e4276c5
@isVoid
fix linestring_distance empty input bug
ad623b3
@isVoid
fix invalid address access
588d309
@isVoid isVoid requested review from a team as code owners May 4, 2023 18:57
@github-actions github-actions bot added the cmake Related to CMake code or build configuration label May 4, 2023
@github-actions github-actions bot added libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels May 4, 2023
@isVoid isVoid changed the title Refactors ST_Distance Column API and Cython Refactor ST_Distance Column API and Cython May 4, 2023
@isVoid isVoid added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 4, 2023
@isVoid isVoid mentioned this pull request May 4, 2023
Closed
3 tasks
harrism
harrism reviewed May 9, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup. The new test fixtures really DRY up the code.

cpp/include/cuspatial/distance.hpp Outdated Show resolved Hide resolved
cpp/include/cuspatial_test/geometry_fixtures.hpp Outdated Show resolved Hide resolved
@isVoid isVoid self-assigned this May 10, 2023
@isVoid
Copy link
Contributor Author

isVoid commented May 16, 2023

/merge

@rapids-bot rapids-bot bot merged commit c6ecbc0 into rapidsai:branch-23.06 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor ST_Distance column API to ensure API homogeneity.
2 participants
@isVoid @harrism