-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11084 Add 'chronos' to unix_users.txt #11086
Conversation
Fix #11084 Add 'chronos' to unix_users.txt
It is required that code in your fork be merged from a unique branch in your repository to master in Rapid7's. Please create a new branch in your fork of framework and resubmit this from that branch.
This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed. Closing based on the this requirement, please do resubmit from a unique branch. |
@bcook-r7 would it be possible to add the branch name check to travis or one of the other compatibility checkers? Seems like a simple check (or maybe put a warning in the PR template). |
I can try to do this if you give me a day. |
|
@h00die The PR template is easy to tweak, it's just the contents of .github/PULL_REQUEST_TEMPLATE.md I'm sure how to ensure a pre-PR check in github though. If you can find a bot that can check this, maybe we could consider enabling that so people don't have to check it. Can houndci do it? I've been considering enabling that, since it can also do Ruby style checks easily enough (see https://github.com/busterb/metasploit-framework/pull/13/files for what the output looks like, and it can be tweaked) |
It's not a big deal. Thanks for the contribution! |
@ole-h This is a long closed PR, there is no need to review this PR. Locking this PR as this issue has been resolved for over a year now. |
This commit adds the username 'chronos' to the user list as it happens to be the default username on ChromeOS, as highlighted by @h00die in Issue #11084