-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashcat equivalents of the jtr modules #11671
Conversation
Wow, this is amazing work! |
If every jtr module could have a hashcat equivalent, could we just rename the existing 'jtr' modules without the tool in the module name, and have them be able to work with whatever cracking tool you have? We might need the 'module name alias' support that @acammack-r7 worked on last year as a PoC, to avoid all of the fallout that might occur from people using the old names. Maybe a later step from this one. |
I have mixed feelings about that @bcook-r7: Combining would save a LOT of duplicate code, but also make for LOT of code branches since each program has different hash input, password output, and flags (like hash type). I have been thinking when this lands to go through both and cleaning them up to be more in sync (and maybe use a table output for cracked passwords) Keeping them separate makes some sense since they are very different beasts. JtR has the Korelogic stuff, hashcat doesn't for example (and this is a minor one). I'm a jtr person, mainly because I don't spend $ for good video cards. With that being said, i made hashcat work, but it is VERY far from optimized or really thought through. However, I'm up for suggestions naturally! Pending this stays as is, priorities:
|
@bcook-r7 any updates on combining jtr and hashcat to one cracking module, or leaving it separate? Also, I started writing https://github.com/rapid7/metasploit-framework/wiki/Hashes-and-Password-Cracking . WIP but putting everything in one place will make my life more sane, so it's bound to help someone else at some point! |
I'm going to go ahead and make an executive call her and shut this down. I'll re-code it into a unified module w/ an |
@acammack-r7 can you point me to the PR with that module name alias functionality? |
No PR, but there is a WIP branch with one commit: acammack-r7@da5881a. There is an issue with aliases interacting with the new module cache backend : After fixing the interaction with the module cache, the next step would be to added an field/method to modules with the name they were invoked with (I want to pass it to |
This adds hashcat modules for all existing jtr modules. #11351
It adds the ability to export creds into hashcat format. #11615
Help me plz
I have one bug I can't figure out.
https://github.com/rapid7/metasploit-framework/pull/11671/files#diff-1078f7f42f6c70928adb5b154ffb1adeR31 is a direct copy of
metasploit-framework/lib/msf/core/auxiliary/jtr.rb
Line 32 in 6218d89
However, when I uncomment it, I get the following error which I was never able to track down why:
Verification
I used the following for test cases. It should crack everything but the mssql12 one.
Wiki
Writing https://github.com/rapid7/metasploit-framework/wiki/Hashes-and-Password-Cracking to help document a lot of this stuff