Moved bruteforce(ip) under the sys_name check.

[jnqpblc]

Moving the bruteforce(ip) under the sys_name check stops the script from executing against the wrong systems.

[bcoles]

That unless block is starting to get a little crowded:

    sys_name = get_system_name(res)
    unless sys_name.blank?
      print_good("System name detected: #{sys_name}")
      report_note(
        :host => ip,
        :type => "system.name",
        :data => sys_name
      )
      if anonymous_access?(res)
        print_good("No login necessary. Server allows anonymous access.")
        return
      end
      init_loginscanner(ip)
      bruteforce(ip)
    end

Also, the module will print nothing at all if sys_name.blank?

Something like this would be a good idea:

    sys_name = get_system_name(res)

    if sys_name.blank?
      print_error 'Could not retrieve system name'
      return
    end

    print_good("System name detected: #{sys_name}")
    report_note(
      :host => ip,
      :type => "system.name",
      :data => sys_name
    )

    if anonymous_access?(res)
      print_good("No login necessary. Server allows anonymous access.")
      return
    end

    init_loginscanner(ip)
    bruteforce(ip)

[jnqpblc]

Yep that worked for me. The only additional thing I see is to move the sys_name = get_system_name(res) and if sys_name.blank? blocks above the version = get_version(res).

    if sys_name.blank?
      print_error 'Could not retrieve system name'
      return
    end

    version = get_version(res)
    unless version.blank?
      print_status("Version detected: #{version}")
      unless is_version_tested?(version)
        print_warning("You're running the module against a version we have not tested")
      end
    end

    print_good("System name detected: #{sys_name}")
    report_note(
      :host => ip,
      :type => "system.name",
      :data => sys_name
    )

    if anonymous_access?(res)
      print_good("No login necessary. Server allows anonymous access.")
      return
    end

    init_loginscanner(ip)
    bruteforce(ip)
  end

[wchen-r7]

Release Notes

This adds a check for system name in HP System Management Homepage Login Utility.