[PLGN-560] Update Proofpoint task schema #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski-r7
approved these changes
Oct 26, 2023
llaszuk-r7
approved these changes
Oct 26, 2023
igorski-r7
deleted the
PLGN-560-update-proofpoint-task-handling-schema
branch
pedro-securo
pushed a commit
to trendmicro/v1-connector-rapid7
that referenced
this pull request
Oct 26, 2023
…ning) (rapid7#2075) Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Oct 27, 2023
…ning) (#2075) Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Oct 27, 2023
* [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Updated task schema to allow for empty fields (due to removal of cleaning) (#2075) Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
added a commit
that referenced
this pull request
Oct 30, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * PLGN-434: add info logs and support missing regions. (#2039) * Update trigger | update pathing | update github branch refs (#2047) * plgn-430 cutoff implementation (#2063) * Mimecast - 425 - Updated pagination handler | Removed token input parameter (#2068) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Updated task schema to allow for empty fields (due to removal of cleaning) (#2075) Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Mimecast - 425 - Changed max request time (#2078) * [MC-1506] Update SentinelOne plugin (#2001) * [MC-1506] Update SentinelOne plugin * [MC-1506] Fix prospector * [MC-1506] Code refactor * [MC-1506] Reformat and fix Static Code Analysis errors * [MC-1506] Resolve comments * pytmv1 version bump --------- Co-authored-by: Dympna Laverty <118898375+dlaverty-r7@users.noreply.github.com> Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com> Co-authored-by: Johnny O'Neill <139136675+joneill-r7@users.noreply.github.com> Co-authored-by: ablakley-r7 <96182471+ablakley-r7@users.noreply.github.com> Co-authored-by: igorski-r7 <99184344+igorski-r7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Accidentally refreshed before committing this file in #2069 and therefore removed the manual update required to the schema to allow for blank fields (e.g. when a field in the event contains an empty string). This was causing the schema validation to fail. Tested again using Postman to ensure the validation passes as expected.
Note: Haven't updated version etc as this is currently only on staging and hasn't been pushed to production.