[PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski-r7
approved these changes
Feb 14, 2023
llaszuk-r7
approved these changes
Feb 14, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Feb 15, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Feb 17, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Feb 17, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
llaszuk-r7
added a commit
that referenced
this pull request
Feb 20, 2023
* [PLGN-133] Samanage updates (#1609) * Updated to latest SDK to avoid SSL cert error. Added examples for all actions * Updated to latest SDK to avoid SSL cert error. Added examples for all actions * Updated to latest SDK to avoid SSL cert error. Added examples for all actions * Updated to latest SDK to avoid SSL cert error. Added examples for all actions * Updated to latest SDK to avoid SSL cert error. Added examples for all actions * Updated to latest SDK to avoid SSL cert error. Added examples for all actions * Regenerated for checksum * Updated for validation * Update exception handling * Updates for confidentiality validator * Updates for confidentiality validator * Updates for confidentiality validator * Updates for confidentiality validator * Updated name to Example User in examples * Regenerated update to checksum * Updated problem to be an array of samanage_problem as this was causing errors * Updated to use solarwinds terminology * Added delete incident action * Updated example for validation check * Updated example for validation check * Removed test from assign incident action * Updated help examples * Updated assignee type * Updated examples for plugin violations * Updated supported versions * Updated supported versions * Updated spacing in help.md * Updated layout of delete incident and api files * Updated layout of delete incident and api files * Added import for pluginexception * Updated .CHECKSUM * Updated spacing in help.md * Updated spacing in help.md --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds/Samanage unit tests (#1630) * Initial unit test skeleton * fix unit tests side effect mock * Added list incident test * Added initial unit tests * Added initial unit tests * Removed unncessary file * Removed unnecessary file * Removed unnecessary test code from the action and trigger files * Unit test updates * Added unit test parameter and responses * Added unit test parameter and responses * Removed unnecessary code * Fixed linting errors * Update plugins/samanage/komand_samanage/connection/connection.py Co-authored-by: igorski-r7 <99184344+igorski-r7@users.noreply.github.com> * Added parameterized to requirements for unit tests * Updated formatting * Updated formatting * Updated formatting on parameters unit test files * Updated formatting on parameters unit test files * Removed accidental line duplication * Adde timeout decorator to requirements file --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: llaszuk <lukasz_laszuk@rapid7.com> Co-authored-by: igorski-r7 <99184344+igorski-r7@users.noreply.github.com> --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: llaszuk <lukasz_laszuk@rapid7.com> Co-authored-by: igorski-r7 <99184344+igorski-r7@users.noreply.github.com>
llaszuk-r7
pushed a commit
that referenced
this pull request
Feb 20, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Feb 20, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
llaszuk-r7
added a commit
that referenced
this pull request
Feb 20, 2023
…1634) * [MC-1361] Add Bitwarden plugin (#1603) * [MC-1359] Add Bitwarden plugin * [MC-1359] Fix prospector * [MC-1361] Change docker image version to slim * [MC-1361] Set plugin as cloud_ready, update supported versions * [MC-1361] Bitwarden plugin fix (#1618) * [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * plgn-157 change schema for detection_rule_rrn --------- Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Dympna Laverty <118898375+dlaverty-r7@users.noreply.github.com> Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Feb 21, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Feb 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Feb 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Feb 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Mar 1, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Mar 1, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Mar 1, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Mar 7, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Mar 7, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Mar 8, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Mar 8, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Mar 13, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Mar 14, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
llaszuk-r7
pushed a commit
that referenced
this pull request
Mar 15, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Mar 20, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 1, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 1, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 2, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 6, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 7, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
joneill-r7
pushed a commit
that referenced
this pull request
Nov 7, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 9, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 10, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 14, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 15, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 16, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
jerichardson-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
dlaverty-r7
added a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
jerichardson-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
jerichardson-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 22, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 22, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Nov 23, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Nov 23, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Nov 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
dlaverty-r7
added a commit
that referenced
this pull request
Nov 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
igorski-r7
pushed a commit
that referenced
this pull request
Nov 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 27, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 28, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 28, 2023
…h expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed when testing the previous Samanage PR that although I had forced all ids output to be strings (either integer or string can be output), that this made it trickier for the workflow use case due to input ids needing to be integers.
Updated to force output ids to be integers instead.
Successfully tested in dev environment.