[SOAR-14571] - Zoom - Delete User Returns Json Parsing Error

[TKuzas-R7]

Proposed Changes

Description

Describe the proposed changes:

• Moved check for 204 status code above checks for 4xx status codes to avoid json parsing errors.
• removed mapping of status codes so that .json() is only called once
• Added Examples to plugin spec
• fixed failing unit test
• updated imports for unit tests

PR Requirements

Developers, verify you have completed the following items by checking them off:

Testing

Unit Tests

Review our documentation on generating and writing plugin unit tests

• Unit tests written for any new or updated code

In-Product Tests

If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:

• Screenshot of job output with the plugin changes
• Screenshot of the changed connection, actions, or triggers input within the InsightConnect workflow builder

Style

Review the style guide

• For dependencies, pin OS package and Python package versions
• For security, set least privileged account with USER nobody in the Dockerfile when possible
• For size, use the slim SDK images when possible: komand/python-3-37-slim-plugin and komand/python-3-37-plugin
• For error handling, use of PluginException and ConnectionTestException
• For logging, use self.logger
• For docs, use changelog style
• For docs, validate markdown with make validate which calls mdl to lint help.md

Functional Checklist

• Work fully completed
• Functional
  • Any new actions/triggers include JSON test files in the tests/ directory created with icon-plugin run -c sample $action > tests/$action.json
  • Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
  • Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
  • Add functioning test results to PR, sanitize any output if necessary
    • Single action/trigger icon-plugin run -T tests/example.json --debug --jq
    • All actions/triggers shortcut icon-plugin run -T all --debug --jq (use PR format at end)
  • Add functioning run results to PR, sanitize any output if necessary
    • Single action/trigger icon-plugin run -R tests/example.json --debug --jq
    • All actions/triggers shortcut icon-plugin run -R all --debug --jq (use PR format at end)

Assessment

You must validate your work to reviewers:

1. Run make validate and make sure everything passes
2. Run the assessment tool: icon-plugin run -A -R all -T all. For single action validation: icon-plugin run -A -R tests/my_action.json -T tests/my_action.json
3. Copy (icon-plugin ... | pbcopy) and paste the output in a new post on this PR
4. Add required screenshots from the In-Product Tests section

[ablakley-r7]

Looks great, have a few comments. Can I also check that we've a test case for the new error code in our unit tests?

[TKuzas-R7]

There is a test for it yes,
the unit test didnt catch the issue because it was being mocked.
It looks like the Integration tests do a better job finding the issues.

[cmcnally-r7]

one small thing