Reword test block to better match assertion #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not.
quii
pushed a commit
that referenced
this pull request
Oct 8, 2020
* Update outdated descriptions and links (#358) * Update reflection.md (#361) Code examples for chan and func are incorrect * Update select.md (#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * specifying what files need to be created Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
quii
pushed a commit
that referenced
this pull request
Oct 9, 2020
* Update outdated descriptions and links (#358) * Update reflection.md (#361) Code examples for chan and func are incorrect * Update select.md (#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * specifying what files need to be created * adding final file comments to http chapter * typo fixes Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
quii
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Update outdated descriptions and links (#358) * Update reflection.md (#361) Code examples for chan and func are incorrect * Update select.md (#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * first quarter of edits * 2nd quarter of chapter copy updates * third quart of chapter's copy changes * copy change to instructions and example (combining instructions to create a single code example) * adding code example * finishing up edits for io * copy changes for cli * Revert "copy changes for cli" This reverts commit 1d9aff2. Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
quii
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Update outdated descriptions and links (#358) * Update reflection.md (#361) Code examples for chan and func are incorrect * Update select.md (#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * edits up to ##Embedding * adding file names to code examples * adding file name comments to code examples * adding instructions for implementing leagues for other tests in server_test * Revert "adding instructions for implementing leagues for other tests in server_test" This reverts commit cae023d. * rest of file name comments added * rewording and clarifying jsonContentType constant copy Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
yuchen
pushed a commit
to go-proj/learn-go-with-tests
that referenced
this pull request
Mar 5, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * specifying what files need to be created Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
yuchen
pushed a commit
to go-proj/learn-go-with-tests
that referenced
this pull request
Mar 5, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * specifying what files need to be created * adding final file comments to http chapter * typo fixes Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
yuchen
pushed a commit
to go-proj/learn-go-with-tests
that referenced
this pull request
Mar 5, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * first quarter of edits * 2nd quarter of chapter copy updates * third quart of chapter's copy changes * copy change to instructions and example (combining instructions to create a single code example) * adding code example * finishing up edits for io * copy changes for cli * Revert "copy changes for cli" This reverts commit 1d9aff2. Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
yuchen
pushed a commit
to go-proj/learn-go-with-tests
that referenced
this pull request
Mar 5, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * edits up to ##Embedding * adding file names to code examples * adding file name comments to code examples * adding instructions for implementing leagues for other tests in server_test * Revert "adding instructions for implementing leagues for other tests in server_test" This reverts commit cae023d. * rest of file name comments added * rewording and clarifying jsonContentType constant copy Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
gypsydave5
pushed a commit
to gypsydave5/learn-go-with-tests
that referenced
this pull request
Jun 11, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * specifying what files need to be created Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
gypsydave5
pushed a commit
to gypsydave5/learn-go-with-tests
that referenced
this pull request
Jun 11, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * specifying what files need to be created * adding final file comments to http chapter * typo fixes Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
gypsydave5
pushed a commit
to gypsydave5/learn-go-with-tests
that referenced
this pull request
Jun 11, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * first quarter of edits * 2nd quarter of chapter copy updates * third quart of chapter's copy changes * copy change to instructions and example (combining instructions to create a single code example) * adding code example * finishing up edits for io * copy changes for cli * Revert "copy changes for cli" This reverts commit 1d9aff2. Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
gypsydave5
pushed a commit
to gypsydave5/learn-go-with-tests
that referenced
this pull request
Jun 11, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * edits up to ##Embedding * adding file names to code examples * adding file name comments to code examples * adding instructions for implementing leagues for other tests in server_test * Revert "adding instructions for implementing leagues for other tests in server_test" This reverts commit cae023d. * rest of file name comments added * rewording and clarifying jsonContentType constant copy Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've been following this repo to help teach myself go and it's been a great help.
I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not.