Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword test block to better match assertion #371

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Reword test block to better match assertion #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update select.md 
Hi all,

I've been following this repo to help teach myself go and it's been a great help.
I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not.
  • Loading branch information
@BClark88
BClark88 authored Aug 31, 2020
commit e2f3eec373a4a121e898ca5bbeebf0ce6ab15fb4
2 changes: 1 addition & 1 deletion select.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ func TestRacer(t *testing.T) {
}
})

t.Run("returns an error if a server doesn't respond within 10s", func(t *testing.T) {
t.Run("returns an error if a server doesn't respond within the specified time", func(t *testing.T) {
server := makeDelayedServer(25 * time.Millisecond)

defer server.Close()
Expand Down