Copy Updates for "JSON, routing, & embedding" #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cpustejovsky
commented
Oct 16, 2020
cpustejovsky
commented
- Added where code examples live in comments
- Added some instructions to make clear what needs to be updated where.
Code examples for chan and func are incorrect
Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not.
…in server_test" This reverts commit cae023d.
|
@quii If this looks good, please add the "hacktoberfest-accepted" label to the PR |
yuchen
pushed a commit
to go-proj/learn-go-with-tests
that referenced
this pull request
Mar 5, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * edits up to ##Embedding * adding file names to code examples * adding file name comments to code examples * adding instructions for implementing leagues for other tests in server_test * Revert "adding instructions for implementing leagues for other tests in server_test" This reverts commit cae023d. * rest of file name comments added * rewording and clarifying jsonContentType constant copy Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
gypsydave5
pushed a commit
to gypsydave5/learn-go-with-tests
that referenced
this pull request
Jun 11, 2021
* Update outdated descriptions and links (quii#358) * Update reflection.md (quii#361) Code examples for chan and func are incorrect * Update select.md (quii#371) Hi all, I've been following this repo to help teach myself go and it's been a great help. I noticed on line 399 the first argument in t.Run doesn't match the assertion. Raising this PR for your consideration as to whether you think this wording fits better or not. * edits up to ##Embedding * adding file names to code examples * adding file name comments to code examples * adding instructions for implementing leagues for other tests in server_test * Revert "adding instructions for implementing leagues for other tests in server_test" This reverts commit cae023d. * rest of file name comments added * rewording and clarifying jsonContentType constant copy Co-authored-by: 森 優太 mori <59682979+uta-mori@users.noreply.github.com> Co-authored-by: Johan Baaij <johanbaaij@gmail.com> Co-authored-by: Brady <37232811+BClark88@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.