fix #2773 #2993
Merged
fix #2773 #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElDeveloper
reviewed
Apr 24, 2020
qiita_pet/handlers/qiita_redbiom.py
Outdated
| timestamps = [] | ||
|
|
||
| if timestamps: | ||
| latests_release = timestamps[0] |
There was a problem hiding this comment.
This is minor but the variable name should be latest_releases right? If you agree then make sure to also update the template.
There was a problem hiding this comment.
Happy to change but note that is only taking one by [0]
There was a problem hiding this comment.
Gotcha, then latest_release should work well.
|
Thanks @antgonza! |
ElDeveloper
added a commit
that referenced
this pull request
Apr 27, 2020
* fix EBI-ENA submission with already submitted samples * fixing errors * fixing errors * fixing errors * readd tests * addressing @ElDeveloper comment * Updating metatranscriptome documentation (#2991) * Update processing-recommendations.rst Adding metatranscriptome processing documentation:Sortmerna for robosomla read filtering * Update processing-recommendations.rst Adding metatranscriptome processing documentation:Sortmerna for ribosomal read filtering * Update qiita_pet/support_files/doc/source/processingdata/processing-recommendations.rst change as suggested Co-Authored-By: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> * Update qiita_pet/support_files/doc/source/processingdata/processing-recommendations.rst Change as suggested Co-Authored-By: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> * Update qiita_pet/support_files/doc/source/processingdata/processing-recommendations.rst Change as suggested Co-Authored-By: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> Co-authored-by: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> * fix #2773 (#2993) * fix #2773 * addressing @ElDeveloper comment * addressing @ElDeveloper comment Co-authored-by: Smruthi Karthik <62975701+smruthi98@users.noreply.github.com> Co-authored-by: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally #2773 was created as the qiita redbiom page displayed the incorrect information of when redbiom was deployed. This PR adds that information to the page; thus it should close that issue.