fix EBI-ENA submission with already submitted samples #2992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2992 +/- ##
==========================================
- Coverage 95.02% 94.97% -0.05%
==========================================
Files 74 74
Lines 14081 14124 +43
==========================================
+ Hits 13380 13414 +34
- Misses 701 710 +9
Continue to review full report at Codecov.
|
antgonza
commented
Apr 14, 2020
* Update processing-recommendations.rst Adding metatranscriptome processing documentation:Sortmerna for robosomla read filtering * Update processing-recommendations.rst Adding metatranscriptome processing documentation:Sortmerna for ribosomal read filtering * Update qiita_pet/support_files/doc/source/processingdata/processing-recommendations.rst change as suggested Co-Authored-By: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> * Update qiita_pet/support_files/doc/source/processingdata/processing-recommendations.rst Change as suggested Co-Authored-By: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> * Update qiita_pet/support_files/doc/source/processingdata/processing-recommendations.rst Change as suggested Co-Authored-By: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu> Co-authored-by: Yoshiki Vázquez Baeza <yoshiki@ucsd.edu>
* fix qiita-spots#2773 * addressing @ElDeveloper comment
ElDeveloper
reviewed
Apr 27, 2020
…a into updates-EBI-ENA-submission
|
Thanks @antgonza ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The big change is that before we could "update" the sample information and now it's not allowed, so basically we need to skip any sample that has been previously submitted from the sample information - note that it is still added in the experiment.